[OE-core] [PATCH 2/4] perl: upgrade to 5.26.1

[Randy MacLeod]

Waiting for a build so I thought I'd comment on this commit.

My comments are about style and maintenance not functionality
which others have covered (the gentoo comment).

On 2017-10-12 02:35 PM, leonardo.sandoval.gonzalez at linux.intel.com wrote:
> From: Leonardo Sandoval<leonardo.sandoval.gonzalez at linux.intel.com>
>
> Highlights:
>
>      * Patches rebased to 5.26.1 and just one removed
That leaves 5 patches that are 'pending'.

Robert, Hongxu, Wenzong,
You guys added these upstream pending patches.
Are the patches you send still pending or were they rejected?

Please elect one of the three of you to follow-up with a patch
if the status has changed and otherwise ping upstream perl
to get these patches merged so we can drop them locally.

>
>      * Several configs values taken from upstream script uconfig[64].sh were introduced in
>      config.sh, avoiding pre-processor issues.
>
>      * Several libraries paths now included a './' as prefix, because @INC does not
>      include local paths.
>
>      * Manifypods is excluded from compilation due to compilation errors (see patch for
>      more info)
>
>      * New perl creates a static library (<libdir>/auto/Unicode/Normalize/Normalize.a) thus
>      there is a new staticdev package.
>
> New packages included (compared to previous version):
>
>      perl-module-math-bigint-lib
>      perl-module-test2
>      perl-module-test2-api
>      perl-module-test2-api-breakage
>      perl-module-test2-api-context
>      perl-module-test2-api-instance
>      perl-module-test2-api-stack
>      perl-module-test2-event
>      perl-module-test2-event-bail
>      perl-module-test2-event-diag
>      perl-module-test2-event-encoding
>      perl-module-test2-event-exception
>      perl-module-test2-event-generic
>      perl-module-test2-event-info
>      perl-module-test2-event-note
>      perl-module-test2-event-ok
>      perl-module-test2-event-plan
>      perl-module-test2-event-skip
>      perl-module-test2-event-subtest
>      perl-module-test2-event-tap-version
>      perl-module-test2-event-waiting
>      perl-module-test2-formatter
>      perl-module-test2-formatter-tap
>      perl-module-test2-hub
>      perl-module-test2-hub-interceptor
>      perl-module-test2-hub-interceptor-terminator
>      perl-module-test2-hub-subtest
>      perl-module-test2-ipc
>      perl-module-test2-ipc-driver
>      perl-module-test2-ipc-driver-files
>      perl-module-test2-tools-tiny
>      perl-module-test2-util
>      perl-module-test2-util-externalmeta
>      perl-module-test2-util-hashbase
>      perl-module-test2-util-trace

The list of these test2 modules could be shorted to

     perl-module-test2
     perl-module-test2-api
     ...
     perl-module-test2-util-trace

but that's probably long long bikeshedding
so at least your shed is painted.

>      perl-module-test-builder-formatter
>      perl-module-test-builder-tododiag
>      perl-module-unicode-collate-locale-de-at-ph
>      perl-module-unicode-collate-locale-fr-ca
>      perl-module-unicode-collate-locale-he
>      perl-module-unicode-collate-locale-ug-cyrl
>      perl-module-unicode-collate-locale-vo
>      perl-module-unicode-normalize-staticdev
>
> Signed-off-by: Leonardo Sandoval<leonardo.sandoval.gonzalez at linux.intel.com>


I like that your package update log has a summary of what's changed *in* 
the package,

in addition to what's changed in the recipe. It would be nice if more 
people did that.


Shame about the perl madness as reported by the gentoo devs.

-- 
# Randy MacLeod.  WR Linux
# Wind River an Intel Company

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20171014/7915b6a0/attachment-0002.html>