[OE-core] [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally

[ChenQi]

I've created YOCTO#12227 
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=12227).
And I've sent out a patch, adding ssh to HOSTTOOLS_NONFATAL.
Another way to fix things up is to add ssh to HOSTTOOLS and change 
QuickStart accordingly.
Either way is acceptable for me.
I'm using the first solution as I'm slightly leaning to it.

Best Regards,
Chen Qi

On 10/13/2017 10:40 AM, Khem Raj wrote:
> On Thu, Oct 12, 2017 at 7:35 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
>> I just got bunch of do_fetch errors from components using
>> git://....;protocol=ssh
>>
>> So it isn't just the sanity check and CONNECTIVITY_CHECK_URIS, it's
>> everywhere where git-native (by default in ASSUME_PROVIDED) is used with
>> ssh.
> right, I realised that it wont make the situation worse, then it was
> in last release,
>
>> On Thu, Oct 12, 2017 at 1:34 PM, Burton, Ross <ross.burton at intel.com> wrote:
>>> On 12 October 2017 at 06:01, Khem Raj <raj.khem at gmail.com> wrote:
>>>> On Wed, Oct 11, 2017 at 9:32 PM, Paul Eggleton
>>>> <paul.eggleton at linux.intel.com> wrote:
>>>>> On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
>>>>>> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa at gmail.com>
>>>>>> wrote:
>>>>>>> On Mon, Oct 09, 2017 at 09:09:31AM +0000, git at git.openembedded.org
>>>>>>> wrote:
>>>>>>>> --- a/meta/conf/bitbake.conf
>>>>>>>> +++ b/meta/conf/bitbake.conf
>>>>>>>> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>>>>>>>>   "
>>>>>>>>
>>>>>>>>   # Tools needed to run testimage runtime image testing
>>>>>>>> -HOSTTOOLS += "ip ping ps scp ssh stty"
>>>>>>>> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh
>>>>>>>> stty'][bb.data.inherits_class('testimage', d)]}"
>>>>>>> Shouldn't we include at least ssh by default?
>>>>>> I would say no, since nothing in OE-Core depends on it. more we
>>>>>> abstract from host system better it is.
>>>>> I'm with Martin on this one, let's not make it painful for people to
>>>>> use
>>>>> the SSH protocol in git URLs in their recipes. I don't see much
>>>>> potential
>>>>> for host contamination.
>>>> Standard distro do not install ssh, if we want to add it here, probably
>>>> we
>>>> should at the same time let user know that he should install ssh
>>>
>>> That's what HOSTTOOLS_NONFATAL is for.  Who is going to claim the glory
>>> and post a patch?
>>>
>>> Ross
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>