[OE-core] [PATCH V2 1/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL

[Denys Dmytriyenko]

On Tue, Oct 17, 2017 at 10:31:11AM +0800, ChenQi wrote:
> On 10/17/2017 10:18 AM, Denys Dmytriyenko wrote:
> >On Tue, Oct 17, 2017 at 09:46:32AM +0800, Chen Qi wrote:
> >>We changed to make tools required by testimage to be included conditionally.
> >>This resulted in users who use ssh for git fetching having failures.
> >>
> >>Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
> >>
> >>[YOCTO #12227]
> >>
> >>Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
> >>---
> >1. Why don't people specify what has changed between v1 and v2 of the patch?
> 
> It's in [OE-core] [PATCH V2 0/1] bitbake.conf: add ssh to
> HOSTTOOLS_NONFATAL.

The changelog between patch revisions?


> >2. A corrected/sorted patch already went in earlier:
> >http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a
> 
> Sorry. My carelessness.
> I should have checked the latest master.
> 
> Best Regards,
> Chen Qi
> >
> >>  meta/conf/bitbake.conf | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> >>index 0eefb86..4fba9d6 100644
> >>--- a/meta/conf/bitbake.conf
> >>+++ b/meta/conf/bitbake.conf
> >>@@ -487,7 +487,7 @@ HOSTTOOLS += " \
> >>  HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
> >>  # Link to these if present
> >>-HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
> >>+HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
> >>  # Temporary add few more detected in bitbake world
> >>  HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> >>-- 
> >>1.9.1
> >>
> >>-- 
> >>_______________________________________________
> >>Openembedded-core mailing list
> >>Openembedded-core at lists.openembedded.org
> >>http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
>