[OE-core] [meta][PATCH 2/3] Fix some issues in the fitImage generation
André Draszik
git at andred.net
Thu Oct 26 10:28:50 UTC 2017
Hi Thomas,
On Wed, 2017-10-25 at 20:03 +0200, Thomas Perrot wrote:
> Ignore fitImage type in do_bundle_initramfs task because the packaging is
> made by do_assemble_fitimage_initramfs
You should also follow the instructions from the patchtest email you're
receiving
http://lists.openembedded.org/pipermail/openembedded-core/2017-October/143668.html
In particular https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Otherwise your patches won't be merged.
In this case, you should prefix your patch subject line with the <target>,
and it's always helpful to add some log output e.g.
---snip---
kernel.bbclass: support fitImage and INITRAMFS_IMAGE_BUNDLE together
When enabling INITRAMFS_IMAGE_BUNDLE and fitImages, the build
aborts because
| mv: cannot stat 'arch/arm64/boot/fitImage': No such file or directory
| WARNING: .../temp/run.do_bundle_initramfs.30337:1 exit 1 from 'mv -f arch/arm64/boot/$type arch/arm64/boot/$type.initramfs'
| ERROR: Function failed: do_bundle_initramfs (log file is located at .../temp/log.do_bundle_initramfs.30337)
| ERROR: Task (kernel.bb.bb:do_bundle_initramfs) failed with exit code '1'
This is because do_bundle_initramfs incorrectly treats 'fitImage'
as a kernel make target that needs to be re-run to achieve initramfs
image bundling, which it shouldn't.
Fix by simply skipping 'fitImage' in this case.
Signed-off-by: ...
---snap---
Same for all the other patches.
We'll get there :-)
Cheers,
Andre'
>
> Signed-off-by: Thomas Perrot <thomas.perrot at tupi.fr>
> ---
> meta/classes/kernel.bbclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 756707a3c2..7f8c8985f3 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -208,7 +208,9 @@ do_bundle_initramfs () {
> # Backing up kernel image relies on its type(regular file
> or symbolic link)
> tmp_path=""
> for type in ${KERNEL_IMAGETYPES} ; do
> - if [ -h ${KERNEL_OUTPUT_DIR}/$type ] ; then
> + if [ "$type" = "fitImage" ] ; then
> + continue
> + elif [ -h ${KERNEL_OUTPUT_DIR}/$type ] ; then
> linkpath=`readlink -n
> ${KERNEL_OUTPUT_DIR}/$type`
> realpath=`readlink -fn
> ${KERNEL_OUTPUT_DIR}/$type`
> mv -f $realpath $realpath.bak
> --
> 2.13.6
>
More information about the Openembedded-core
mailing list