[OE-core] [PATCH][resend] insane.bbclass: Warn if ${COREBASE}/LICENSE is used

[Burton, Ross]

This and the other patch have been wrapped by your mailer, and also base64
encoded so I can't trivially fix the whitespace.  Are they in a branch, or
can you resend them using git-send-email?

Ross

On 31 August 2017 at 23:40, Saul Wold <sgw at linux.intel.com> wrote:

> The top level LICENSE file is not actually a license, it refers
> other licenses that are used by Bitbake and Meta-data. Relying
> on this file could cause problems for recipes when this file
> changes, which it is about to.
>
> Signed-off-by: Saul Wold <sgw at linux.intel.com>
> ---
>  meta/classes/insane.bbclass | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 479d39c..6d20eb6 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -659,7 +659,7 @@ python populate_lic_qa_checksum() {
>          sane = package_qa_handle_error("license-checksum", pn + ":
> Recipe file fetches files and does not have license file information
> (LIC_FILES_CHKSUM)", d)
>
>      srcdir = d.getVar('S')
> -
> +    corebase_licensefile = d.getVar('COREBASE') + "/LICENSE"
>      for url in lic_files.split():
>          try:
>              (type, host, path, user, pswd, parm) =
> bb.fetch.decodeurl(url)
> @@ -670,6 +670,10 @@ python populate_lic_qa_checksum() {
>          if not os.path.isfile(srclicfile):
>              package_qa_handle_error("license-checksum", pn + ":
> LIC_FILES_CHKSUM points to an invalid file: " + srclicfile, d)
>              continue
> +
> +        if (srclicfile == corebase_licensefile):
> +            bb.warn("${COREBASE}/LICENSE is not a valid license file,
> please use '${COMMON_LICENSE_DIR}/MIT' for a MIT License file in
> LIC_FILES_CHKSUM")
> +            bb.warn("This will become an error in the next release")
>
>          recipemd5 = parm.get('md5', '')
>          beginline, endline = 0, 0
> --
> 2.7.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170901/8af6a5fd/attachment-0002.html>