[OE-core] EXT: Re: [PATCH 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS

[Jose Alarcon]

On 02.09.2017 14:46, Richard Purdie wrote:
> On Sat, 2017-08-26 at 14:26 +0300, Jose Alarcon wrote:
>> The do_rootfs log contains a number of unsatisfied package
>> recommendations. At the moment those are only visible when
>> reviewing the rootfs log.
>>
>> This patch adds an extra check to surface any unsatisfied
>> recommendation  as WARNINGS to the build output when
>> "debug-tweaks" is enabled.
>>
>> Signed-off-by: Jose Alarcon <jose.alarcon at ge.com>
>> ---
>>  meta/classes/rootfs-postcommands.bbclass | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/meta/classes/rootfs-postcommands.bbclass
>> b/meta/classes/rootfs-postcommands.bbclass
>> index fb36bad..e7ef382 100644
>> --- a/meta/classes/rootfs-postcommands.bbclass
>> +++ b/meta/classes/rootfs-postcommands.bbclass
>> @@ -50,6 +50,9 @@ python () {
>>      d.appendVar('ROOTFS_POSTPROCESS_COMMAND',
>> '${SORT_PASSWD_POSTPROCESS_COMMAND}')
>>  }
>>  
>> +# Enable QA check for unsatisfied recommendations if debug-tweaks is
>> enabled
>> +ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATU
>> RES", "debug-tweaks", "rootfs_log_check_recommends; ", "",d)}'
>> +
>>  systemd_create_users () {
>>  	for conffile in
>> ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd.conf
>> ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd-remote.conf; do
>>  		[ -e $conffile ] || continue
> Can we just drop the above piece please? I think its fine for the user
> to enable this with:
>
> ROOTFS_POSTPROCESS_COMMAND += "rootfs_log_check_recommends"
>
> We're trying to kill off debug-tweaks as nobody can tell what it does
> from the name.

Thanks for your feedback! v2 sent.

Cheers,

--
Jose