[OE-core] [PATCH v3 05/11] goarch.bbclass: Add support for ARMv5

[Otavio Salvador]

On Fri, Sep 8, 2017 at 10:56 AM, Will Newton <will.newton at gmail.com> wrote:
> On Fri, Sep 8, 2017 at 2:47 PM, Otavio Salvador <otavio at ossystems.com.br> wrote:
>> This adds support to return the proper ARMv5 format.
>>
>> This change is based on the meta-golang[1] layer. Thanks to Matt
>> Madison <matt at madison.systems> for his work on this.
>>
>> 1. https://github.com/madisongh/meta-golang
>>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>>  meta/classes/goarch.bbclass | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/goarch.bbclass b/meta/classes/goarch.bbclass
>> index 7960ac5f9e..dbec6ee2c8 100644
>> --- a/meta/classes/goarch.bbclass
>> +++ b/meta/classes/goarch.bbclass
>> @@ -47,6 +47,8 @@ def go_map_arm(a, f, d):
>>      import re
>>      if re.match('arm.*', a) and re.match('arm.*7.*', f):
>>          return '7'
>> +    if re.match('arm.*', a) and re.match('arm.*5.*', f):
>> +        return '5'
>
> I suspect this regular expression is overly general, see:
>
> http://lists.openembedded.org/pipermail/openembedded-core/2017-September/141938.html
>
> The Go toolchain default is for ARMv5 when cross-compiling so as far
> as I know setting this explicitly should have no effect at the moment,
> although it may be valuable to protect against changes to the default.

If you don't mind, I will add your patch in my patchset and rebase
mine on top of this one so we have a single patchset with all this
rework included. Are you Ok with that?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750