[OE-core] [PATCH v8 3/3] kernel-devicetree.bbclass: Add support to generate append to kernel

Otavio Salvador otavio.salvador at ossystems.com.br
Tue Sep 12 20:26:04 UTC 2017


Andreas,

On Tue, Sep 12, 2017 at 4:10 PM, Andreas Oberritter
<obi at opendreambox.org> wrote:
> On Tue, 12 Sep 2017 14:00:43 -0300
> Otavio Salvador <otavio.salvador at ossystems.com.br> wrote:
>> On Tue, Sep 12, 2017 at 11:45 AM, Andreas Oberritter
>> <obi at opendreambox.org> wrote:
>> > Hi Otavio,
>> >
>> > On Tue, 12 Sep 2017 10:45:51 -0300
>> > Otavio Salvador <otavio at ossystems.com.br> wrote:
>> >
>> >> +do_configure_devicetree() {
>> >> +     if [ "${KERNEL_DEVICETREE_BUNDLE}" = "1" ]; then
>> >> +             if echo ${KERNEL_IMAGETYPE_FOR_MAKE} | grep -q 'zImage'; then
>> >> +                     config="${B}/.config"
>> >> +                     if ! grep -q 'CONFIG_ARM_APPENDED_DTB=y' $config; then
>> >> +                             bbwarn 'CONFIG_ARM_APPENDED_DTB is NOT enabled in the kernel. Enabling it to allow the kernel to boot with the Device Tree appended!'
>> >> +                             sed -i "/CONFIG_ARM_APPENDED_DTB[ =]/d" $config
>> >> +                             echo "CONFIG_ARM_APPENDED_DTB=y" >> $config
>> >> +                             echo "# CONFIG_ARM_ATAG_DTB_COMPAT is not set" >> $config
>> >
>> > what about CONFIG_MIPS_APPENDED_DTB?
>> >
>> > Can we ever make sure to cover all relevant architectures?
>>
>> I don't know the details about the MIPS and its appended DTB support.
>> Do you know what we need?
>
> Just the symbol already mentioned above, see [1].
>
> However, I'd argue that the verification of configuration options specific to one
> or two architectures shouldn't be done here at all. Users are responsible to choose
> suitable kernel options.

Ok; I will prepare the patch to support both.

I prefer to mangle the config here so we provide a turn-key support
for it. I am preparing a new patch revision adding it. I've added you
to Cc for the new patchset revision.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list