[OE-core] [PATCH v8 06/13] go-dep: Move bash dependency to -dev package

[Matt Madison]

On Tue, Sep 12, 2017 at 12:21 PM, Khem Raj <raj.khem at gmail.com> wrote:
> On Tue, Sep 12, 2017 at 12:20 PM, Otavio Salvador
> <otavio.salvador at ossystems.com.br> wrote:
>> On Tue, Sep 12, 2017 at 3:58 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
>>> Seems like this version was already picked to master-next, so probably
>>> better to leave as standalone change now.
>>>
>>> The version currently in master fails to build for arm with thumb enabled:
>>> http://errors.yoctoproject.org/Errors/Details/155765/
>>>
>>> Is it fixed somewhere in this new patchset?
>>>
>>> # github.com/golang/dep/cmd/dep
>>> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/recipe-sysroot-native/usr/lib/arm-oe-linux-gnueabi/go/pkg/tool/linux_amd64/link:
>>> R_ARM_THM_CALL, are you using -marm?
>>> WARNING: exit code 2 from a shell command.
>>> ERROR: Function failed: do_compile (log file is located at
>>> TOPDIR/tmp-glibc/work/armv5te-oe-linux-gnueabi/go-dep/0.3.0-r0/temp/log.do_compile.13531)
>>
>> No, it is not.
>>
>> It seems that Go, when using CGO, does not play nice with Thumb. Matt,
>> do you know if there is a known fix for it?
>
> Disable CGO for thumb, we have a variable to select cgo

Yeah, I don't think Go handles Thumb at all. Maybe we should set
ARM_INSTRUCTION_SET to "arm" in goarch.bbclass?

-Matt