[OE-core] [PATCH 2/2] sysvinit-inittab: start_getty: Cleanup comments

Choong, Yin Thong yin.thong.choong at intel.com
Tue Sep 19 05:28:23 UTC 2017


Look's good to me. 

Thanks and Regards
Choong Yin Thong


-----Original Message-----
From: Andrea Adami [mailto:andrea.adami at gmail.com] 
Sent: Saturday, September 16, 2017 7:36 AM
To: openembedded-core at lists.openembedded.org
Cc: Choong, Yin Thong <yin.thong.choong at intel.com>; Saul Wold <sgw at linux.intel.com>; Andrea Adami <andrea.adami at gmail.com>
Subject: [PATCH 2/2] sysvinit-inittab: start_getty: Cleanup comments

Signed-off-by: Andrea Adami <andrea.adami at gmail.com>
---
 .../sysvinit/sysvinit-inittab/start_getty          | 26 +++++++++++-----------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/meta/recipes-core/sysvinit/sysvinit-inittab/start_getty b/meta/recipes-core/sysvinit/sysvinit-inittab/start_getty
index f0d9f8c..e15ae35 100644
--- a/meta/recipes-core/sysvinit/sysvinit-inittab/start_getty
+++ b/meta/recipes-core/sysvinit/sysvinit-inittab/start_getty
@@ -1,16 +1,16 @@
 #!/bin/sh
-####################################################################################
-# This script is use to automatic start serial console once power up.
-# Script enhancement has been done base on Bug YOCTO 10844.
-# Configuration can be done in meta/conf/machine/*.conf variable SERIAL_CONSOLES.
-# Most of the information is retrieve from /proc virtual filesystem which -# contain all the runtime system information (eg. system memory, device mount, etc).
-####################################################################################
+#######################################################################
+######## # This script is used to automatically set up the serial 
+console(s) on startup.
+# The variable SERIAL_CONSOLES can be set in meta/conf/machine/*.conf.
+# Script enhancement has been done based on Bug YOCTO #10844.
+# Most of the information is retrieved from /proc virtual filesystem 
+containing # all the runtime system information (eg. system memory, device mount, etc).
+#######################################################################
+########
 
 # Get active serial filename.
 active_serial=$(grep "serial" /proc/tty/drivers | cut -d/ -f1 | sed "s/ *$//")
 
-# Re-phrase input parameter from ttyS target index (ttyS1, ttyS2, ttyAMA0, etc).
+# Rephrase input parameter from ttyS target index (ttyS1, ttyS2, ttyAMA0, etc).
 runtime_tty=$(echo $2 | grep -oh '[0-9]')
 
 # Backup $IFS.
@@ -19,14 +19,14 @@ DEFAULT_IFS=$IFS
 IFS="$(printf '\n\t')"
 
 for line in $active_serial; do
-	# File is availability, file content current active serial target index.
+	# Check we have the file containing current active serial target index.
 	if [ -e "/proc/tty/driver/$line" ]
         then
-		# File content a lot of unknown serial. We use -v to remove all unmatch and get left off.
-		# Tail use to avoid 1st line included into the filter because 1st line is file description.
-		activetty=$(grep -v "unknown" "/proc/tty/driver/$line" | tail -n +2 | grep -oh "^\s*\S*[0-9]")
+		# Remove all unknown entries and discard the first line (desc).
+		activetty=$(grep -v "unknown" "/proc/tty/driver/$line" \
+			    | tail -n +2 | grep -oh "^\s*\S*[0-9]")
 		for active in $activetty; do
-			# Check if both index is match then proceed to enable the serial console.
+			# If indexes do match then enable the serial console.
 			if [ $active -eq $runtime_tty ]
 			then
 				if [ -c /dev/$2 ]
--
2.7.4




More information about the Openembedded-core mailing list