[OE-core] [PATCH] classes/image: fix do_image_qa dependencies

Tomasz Meresinski tomasz.meresinski at comarch.pl
Wed Sep 20 07:08:55 UTC 2017


Your patch works for me. I think your place for do_image_qa is even better.

Tomasz

On 19.09.2017 18:22, Burton, Ross wrote:
> On 19 September 2017 at 17:07, Burton, Ross <ross.burton at intel.com 
> <mailto:ross.burton at intel.com>> wrote:
>
>     On 19 September 2017 at 11:36, Tomasz Meresiński
>     <tomasz.meresinski at comarch.pl
>     <mailto:tomasz.meresinski at comarch.pl>> wrote:
>
>         After do_image_complete IMAGE_ROOTFS directory is empty so qa
>         checks do not work
>
>
>     Important context: this only happens if rm_work is enabled.  I'm
>     wondering if the task should be moved earlier so its between
>     rootfs and image, as it's actually a *rootfs* QA hook (its
>     expected that functions examine the contents of IMAGE_ROOTFS).
>
>     I think we need to push the task back a bit in the tree and put it
>     in between rootfs and image. This way if it fails the image
>     generation doesn't happen, and rm_work won't break it.
>
>
> I've just sent an alternative patch the list, can you verify that it 
> solves your problem and doesn't break your existing image QA functions?
>
> Cheers,
> Ross
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170920/4b86bbe6/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4957 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170920/4b86bbe6/attachment-0002.p7s>


More information about the Openembedded-core mailing list