[OE-core] [PATCH 2/2] pseudo: Add fastop reply fix

Otavio Salvador otavio.salvador at ossystems.com.br
Fri Sep 22 19:19:18 UTC 2017


Richard,

On Fri, Sep 22, 2017 at 2:12 PM, Alexander Kanavin
<alexander.kanavin at linux.intel.com> wrote:
> On 09/22/2017 07:52 PM, Seebs wrote:
>>>
>>> This changes the pseudo FASTOP functionality so that a reply to the
>>> operation is required. This means we then cannot lose data if a
>>> connection is closed. This in turn stops corruption if we run out of
>>> file handles and have to close connections.
>>>
>>> This tweaks the connection closure patch to update the comment there
>>> which is now outdated.
>>>
>>> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>>
>>
>> This looks reasonable to me. I did some testing with a very similar
>> patch and concluded that, while it slowed performance slightly, it
>> didn't slow it nearly as much as the pre-fastop behavior did.
>
> Also, the issue this patch is fixing is not theoretical. Setting max fd
> limit to a low value (192) is causing errors on my machine:
>
> dpkg-deb: error: maintainer script 'postinst' has bad permissions 644 (must
> be >=0555 and <=0775)
>
> and with the patch they seem to go away.

When queueing it, please make sure to add the proper patch headers.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list