[OE-core] [PATCH 1/2] systemd: change some RRECOMMENDS to RDEPENDS

[ChenQi]

On 09/22/2017 05:34 PM, Martin Jansa wrote:
> This doesn't seem to work correctly for MACHINEs with 
> empty SERIAL_CONSOLE, because with empty SERIAL_CONSOLE there is no 
> systemd-serialgetty package (because it's also empty) and the build 
> fails with:
>
> Collected errors:
>  * calculate_dependencies_for: Cannot satisfy the following 
> dependencies for packagegroup-core-boot:
>  *      systemd-serialgetty *
>  * opkg_solver_install: Cannot install package packagegroup-core-boot.
>
> If you're setting NO_RECOMMENDATIONS to "1", then you should expect 
> that some recommended functionality will be missing, no?
>

Hi Martin,

Thanks a lot for pointing out this situation.
I've sent out a follow-up fix which sets ALLOW_EMPTY_${PN} = "1" in 
systemd-serialtty.bb.
I hope this would be sufficient.

I agree with you that if NO_RECOMMENDATIONS is set to "1", the lack of 
some functionality is allowed.
But if the user doesn't set anything related to serial console, and he's 
building our reference image (e.g. core-image-minimal) on our supported 
BSP (e.g. qemux86-64), the user should not be astonished by being unable 
to get to login.

Anyway, I hope my follow-up fix would fix things up.

Best Regards,
Chen Qi

> On Tue, Sep 5, 2017 at 10:07 AM, Chen Qi <Qi.Chen at windriver.com 
> <mailto:Qi.Chen at windriver.com>> wrote:
>
>     Set NO_RECOMMENDATIONS to "1", build and start a systemd image, and we
>     could not get serial getty spawned, thus causing the user not able to
>     login via serial port.
>
>     E.g.
>     MACHINE=qemux86-64 bitbake core-image-minimal
>     runqemu qemux86-64 nographic
>
>     And we cannot login onto the system.
>
>     Move util-linux-agetty and systemd-serialgetty (determined by
>     PACKAGECONFIG)
>     from RRECOMMENDS to RDEPENDS to fix the above problem.
>
>     Signed-off-by: Chen Qi <Qi.Chen at windriver.com
>     <mailto:Qi.Chen at windriver.com>>
>     ---
>      meta/recipes-core/systemd/systemd_234.bb <http://systemd_234.bb>
>     | 8 ++++----
>      1 file changed, 4 insertions(+), 4 deletions(-)
>
>     diff --git a/meta/recipes-core/systemd/systemd_234.bb
>     <http://systemd_234.bb> b/meta/recipes-core/systemd/systemd_234.bb
>     <http://systemd_234.bb>
>     index 2736f38..2695e15 100644
>     --- a/meta/recipes-core/systemd/systemd_234.bb <http://systemd_234.bb>
>     +++ b/meta/recipes-core/systemd/systemd_234.bb <http://systemd_234.bb>
>     @@ -492,13 +492,13 @@ FILES_${PN} = " ${base_bindir}/* \
>
>      FILES_${PN}-dev += "${base_libdir}/security/*.la
>     ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
>
>     -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})"
>     +RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (=
>     ${EXTENDPKGV}) util-linux-agetty"
>     +RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG',
>     'serial-getty-generator', '', 'systemd-serialgetty', d)}"
>      RDEPENDS_${PN} += "volatile-binds update-rc.d"
>
>     -RRECOMMENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG',
>     'serial-getty-generator', '', 'systemd-serialgetty', d)} \
>     -                      systemd-extra-utils \
>     +RRECOMMENDS_${PN} += "systemd-extra-utils \
>                            systemd-compat-units udev-hwdb \
>     -                      util-linux-agetty  util-linux-fsck
>     e2fsprogs-e2fsck \
>     +                      util-linux-fsck e2fsprogs-e2fsck \
>                            kernel-module-autofs4 kernel-module-unix
>     kernel-module-ipv6 \
>                            os-release \
>      "
>     --
>     1.9.1
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core at lists.openembedded.org
>     <mailto:Openembedded-core at lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170926/0895acf1/attachment-0002.html>