[OE-core] [PATCH] bash: libjpeg-turbo: add -fomit-frame-pointer to DEBUG_OPTIMIZATION for armv[45] with thumb enabled

Burton, Ross ross.burton at intel.com
Mon Aug 6 12:03:23 UTC 2018


Hope you don't mind but the pedant in me split this into two commits
when I merged to mut. ;)

On 5 August 2018 at 20:40, Martin Jansa <martin.jansa at gmail.com> wrote:
> with thumb and debug enabled bash and libjpeg-turbo gets stuck forever
> when building for qemuarm.
>
> bash gets stuck in:
> bash/4.4.18-r0/build/builtins$ arm-webos-linux-gnueabi-gcc  -march=armv5te -mthumb -fstack-protector-strong   --sysroot=bash/4.4.18-r0/recipe-sysroot -c  -DHAVE_CONFIG_H -DSHELL  -I. -I..  -I../../bash-4.4.18 -I../../bash-4.4.18/include -I../../bash-4.4.18/lib -I../../bash-4.4.18/builtins    -O -fno-omit-frame-pointer -g -DNON_INTERACTIVE_LOGIN_SHELLS read.c
> libjpeg-turbo gets stuck in:
> libjpeg-turbo/1_1.5.3-r0/build$ arm-webos-linux-gnueabi-gcc -march=armv5te -mthumb -fstack-protector-strong -Wformat -Wformat-security -Werror=format-security --sysroot=libjpeg-turbo/1_1.5.3-r0/recipe-sysroot -DHAVE_CONFIG_H -I. -I../libjpeg-turbo-1.5.3 -Wall -O -fno-omit-frame-pointer -g -feliminate-unused-debug-types -pipe -c ../libjpeg-turbo-1.5.3/turbojpeg.c  -fPIC -DPIC -o .libs/libturbojpeg_la-turbojpeg.o
>
> when -mthumb, -fstack-protector-strong, -fno-omit-frame-pointer appear
> together, removing one of them is enough for successful build.
>
> similar to:
> http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html
> but in this case the build gets stuck instead of failure
>
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
>  meta/recipes-extended/bash/bash_4.4.18.bb         | 3 +++
>  meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.3.bb | 3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/meta/recipes-extended/bash/bash_4.4.18.bb b/meta/recipes-extended/bash/bash_4.4.18.bb
> index 0b22ca7a69..b338acd9dc 100644
> --- a/meta/recipes-extended/bash/bash_4.4.18.bb
> +++ b/meta/recipes-extended/bash/bash_4.4.18.bb
> @@ -19,4 +19,7 @@ SRC_URI = "${GNU_MIRROR}/bash/${BP}.tar.gz;name=tarball \
>  SRC_URI[tarball.md5sum] = "518e2c187cc11a17040f0915dddce54e"
>  SRC_URI[tarball.sha256sum] = "604d9eec5e4ed5fd2180ee44dd756ddca92e0b6aa4217bbab2b6227380317f23"
>
> +DEBUG_OPTIMIZATION_append_armv4 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}"
> +DEBUG_OPTIMIZATION_append_armv5 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}"
> +
>  BBCLASSEXTEND = "nativesdk"
> diff --git a/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.3.bb b/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.3.bb
> index c453fdd9e0..9e1bc0e34d 100644
> --- a/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.3.bb
> +++ b/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.3.bb
> @@ -41,6 +41,9 @@ EXTRA_OECONF_append_class-target = " ${@bb.utils.contains("MIPSPKGSFX_FPU", "-nf
>  EXTRA_OECONF_append_class-target_powerpc = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "--without-simd", d)}"
>  EXTRA_OECONF_append_class-target_powerpc64 = " ${@bb.utils.contains("TUNE_FEATURES", "altivec", "", "--without-simd", d)}"
>
> +DEBUG_OPTIMIZATION_append_armv4 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}"
> +DEBUG_OPTIMIZATION_append_armv5 = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}"
> +
>  def get_build_time(d):
>      if d.getVar('SOURCE_DATE_EPOCH') != None:
>          import datetime
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



More information about the Openembedded-core mailing list