[OE-core] [ROCKO][PATCH 01/27] binutils: Security fix CVE-2017-12967

[akuster808]

On 08/08/2018 08:34 AM, Armin Kuster wrote:
> From: Armin Kuster <akuster at mvista.com>
>
> affects: <= 2.29.1
>
> Signed-off-by: Armin Kuster <akuster at mvista.com>

This one is really CVE-2017-17124 so it will be renamed in V2

CVE-2017-12967 is already in 2.29.1

> ---
>  meta/recipes-devtools/binutils/binutils-2.29.1.inc |  1 +
>  .../binutils/binutils/CVE-2017-12967.patch         | 47 ++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 meta/recipes-devtools/binutils/binutils/CVE-2017-12967.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.29.1.inc b/meta/recipes-devtools/binutils/binutils-2.29.1.inc
> index b29b75a..12b579c 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.29.1.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.29.1.inc
> @@ -35,6 +35,7 @@ SRC_URI = "\
>       file://0013-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch \
>       file://0014-Detect-64-bit-MIPS-targets.patch \
>       file://0015-sync-with-OE-libtool-changes.patch \
> +     file://CVE-2017-12967.patch \
>  "
>  S  = "${WORKDIR}/git"
>  
> diff --git a/meta/recipes-devtools/binutils/binutils/CVE-2017-12967.patch b/meta/recipes-devtools/binutils/binutils/CVE-2017-12967.patch
> new file mode 100644
> index 0000000..ab19d21
> --- /dev/null
> +++ b/meta/recipes-devtools/binutils/binutils/CVE-2017-12967.patch
> @@ -0,0 +1,47 @@
> +From b0029dce6867de1a2828293177b0e030d2f0f03c Mon Sep 17 00:00:00 2001
> +From: Nick Clifton <nickc at redhat.com>
> +Date: Tue, 28 Nov 2017 18:00:29 +0000
> +Subject: [PATCH] Prevent a memory exhaustion problem when trying to read in
> + strings from a COFF binary with a corrupt string table size.
> +
> +	PR 22507
> +	* coffgen.c (_bfd_coff_read_string_table): Check for an excessive
> +	size of the external string table.
> +
> +Upstream-Status: backport
> +Affects binutls <= 2.29.1
> +CVE:  CVE-2017-12967 
> +Signed-off-by: Armin Kuster <akuster at mvista.com>
> +
> +---
> + bfd/ChangeLog | 6 ++++++
> + bfd/coffgen.c | 4 ++--
> + 2 files changed, 8 insertions(+), 2 deletions(-)
> +
> +Index: git/bfd/coffgen.c
> +===================================================================
> +--- git.orig/bfd/coffgen.c
> ++++ git/bfd/coffgen.c
> +@@ -1709,7 +1709,7 @@ _bfd_coff_read_string_table (bfd *abfd)
> + #endif
> +     }
> + 
> +-  if (strsize < STRING_SIZE_SIZE)
> ++  if (strsize < STRING_SIZE_SIZE || strsize > bfd_get_file_size (abfd))
> +     {
> +       _bfd_error_handler
> + 	/* xgettext: c-format */
> +Index: git/bfd/ChangeLog
> +===================================================================
> +--- git.orig/bfd/ChangeLog
> ++++ git/bfd/ChangeLog
> +@@ -1,3 +1,9 @@
> ++2017-11-28  Nick Clifton  <nickc at redhat.com>
> ++
> ++       PR 22507
> ++       * coffgen.c (_bfd_coff_read_string_table): Check for an excessive
> ++       size of the external string table.
> ++
> + 2018-03-28  Eric Botcazou  <ebotcazou at adacore.com>
> + 
> + 	PR ld/22972