[OE-core] [oe-core][PATCH v3 2/2] runtime selftest: remove the case of hw breakpoint

Randy MacLeod randy.macleod at windriver.com
Thu Aug 9 15:03:14 UTC 2018


On 08/03/2018 05:48 AM, Hongzhi.Song wrote:
> Hw breakpoint is based on hardware.

We need a better commit log explanation.

Was this test added in error originally?

Can you explain briefly whether their are any
qemu configurations would be able to efficiently
test the hardware breakpoint feature using these kernel
modules. For example, if you are running qemux86-64 with
the kvm-intel module in your host's kernel, then the tests
may work and even be efficient. Can you change the test
to detect if the hardware/qemu supports hardware breakpoint
and only run the test if it does?

../Randy

> 
> Signed-off-by: Hongzhi.Song <hongzhi.song at windriver.com>
> ---
>   meta/lib/oeqa/runtime/cases/ksample.py | 16 ----------------
>   1 file changed, 16 deletions(-)
> 
> diff --git a/meta/lib/oeqa/runtime/cases/ksample.py b/meta/lib/oeqa/runtime/cases/ksample.py
> index 26fbe9d8cb..5e8699a2e2 100644
> --- a/meta/lib/oeqa/runtime/cases/ksample.py
> +++ b/meta/lib/oeqa/runtime/cases/ksample.py
> @@ -161,22 +161,6 @@ class KSampleTest(KSample):
>           # rmmod
>           self.cmd_and_check("rmmod trace-printk")
>   
> -    # hw breakpoint
> -    @OETestDepends(['ssh.SSHTest.test_ssh'])
> -    def test_hw_breakpoint_example(self):
> -        # check config
> -        self.check_config("CONFIG_KALLSYMS_ALL")
> -        # make sure if module exists
> -        self.check_module_exist("hw_breakpoint/", "data_breakpoint.ko")
> -        # modprobe
> -        self.cmd_and_check("modprobe data_breakpoint")
> -        # lsmod
> -        self.cmd_and_check("lsmod | grep data_breakpoint | cut -d\' \' -f1", "data_breakpoint")
> -        # check result
> -        self.cmd_and_check("cat /var/log/messages | grep sample_hbp_handler", "sample_hbp_handler")
> -        # rmmod
> -        self.cmd_and_check("rmmod data_breakpoint")
> -
>       @OETestDepends(['ssh.SSHTest.test_ssh'])
>       def test_configfs_sample(self):
>           # check config
> 


-- 
# Randy MacLeod
# Wind River Linux



More information about the Openembedded-core mailing list