[OE-core] [PATCH] rpm: remove depend on dbus for rpm native

Peter Kjellerstedt peter.kjellerstedt at axis.com
Wed Aug 15 09:36:40 UTC 2018


> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org <openembedded-
> core-bounces at lists.openembedded.org> On Behalf Of
> changqing.li at windriver.com
> Sent: den 15 augusti 2018 11:25
> To: openembedded-core at lists.openembedded.org
> Subject: [OE-core] [PATCH] rpm: remove depend on dbus for rpm native
> 
> From: Changqing Li <changqing.li at windriver.com>
> 
> This depend cause a big problem that for one package,
> build enviroment for clean compile and second time compile
> are different. And also rpm-native actually don't need to
> depend on dbus, so remove it.
> 
> Take libfastjson as example:
> (libfastjson don't have autoconf-archive-native in DEPEND)
> if don't remove this dependency, it will have below dependency list:
> libfastjson -> gcc-runtime -> libgcc -> glibc -> linux-libc-headers ->
> rpm-native
> rpm-native -> dbus-native
> dbus-native -> autoconf-archive-native
> 
> in this way:
> do_package of libfastjson will depend on do_populate_sysroot
> of autoconf-archive-native
> 
> for clean compile:
> during do_configure, since do_package not executed,  so .m4 files
> provide by autoconf-archive-native will not under
> recipe_sysroot_native,
> 
> for second time configure:
> .m4 already copy under recipe_sysroot_native when run do_package last
> time
> 
> so if there is code related .m4 of autoconf-archive-native in the
> configure.ac
> there will be differences and may cause problem.
> 
> Signed-off-by: Changqing Li <changqing.li at windriver.com>
> ---
>  meta/recipes-devtools/rpm/rpm_4.14.1.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/rpm/rpm_4.14.1.bb b/meta/recipes-
> devtools/rpm/rpm_4.14.1.bb
> index e5e87d3..91617a4 100644
> --- a/meta/recipes-devtools/rpm/rpm_4.14.1.bb
> +++ b/meta/recipes-devtools/rpm/rpm_4.14.1.bb
> @@ -52,6 +52,7 @@ S = "${WORKDIR}/git"
> 
> 
>  DEPENDS = "nss libarchive db file popt xz bzip2 dbus elfutils python3"
>  DEPENDS_append_class-native = " file-replacement-native bzip2-replacement-native"
> +DEPENDS_remove_class-native = "dbus"

Using _remove should be avoided in recipes since it is very 
hard to override it in a bbappend or .conf file. So I suggest 
this instead:

DEPENDS = "nss libarchive db file popt xz bzip2 elfutils python3"
DEPENDS_append_class-target = " dbus"
DEPENDS_append_class-native = " file-replacement-native bzip2-replacement-native"

> 
>  inherit autotools gettext pkgconfig python3native
>  export PYTHON_ABI
> --
> 2.7.4

//Peter




More information about the Openembedded-core mailing list