[OE-core] [PATCH v6 2/3] openssl-1.1: rework packaging

[Andre McCurdy]

On Thu, Aug 16, 2018 at 12:34 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
> On Tue, Jul 17, 2018 at 2:10 AM, Andrej Valek <andrej.valek at siemens.com> wrote:
>> The main idea is to have libssl and libcrypto in separate packages.
>> This saves space if only single library is needed and also some recipes
>> (in other layers) depend on these library packages.
>> Together with this other packages like in 1.0.x were created.
>> The only difference is that openssl 1.1 has additional package openssl-bin.
>>
>> Add missing dependency to perl for openssl-bin pkg, c_rehash requires it.

That perl dependency needs to be looked at again. By using the
unofficial c_rehash shell script for -native and the official upstream
perl script for the target we get the worst of both worlds - the
maintenance effort of the unofficial shell script and the perl runtime
dependency on the target.

To help users who don't want perl on the target, either the perl
version of c_rehash should go back into openssl-misc (where it always
used to be) or maybe it can now be dropped entirely as "openssl
rehash" seems to be replacement?

  https://www.openssl.org/docs/man1.1.0/apps/rehash.html

>> Signed-off-by: Andrej Valek <andrej.valek at siemens.com>
>> Signed-off-by: Marko Peter <peter.marko at siemens.com>
>> ---
>>  meta/recipes-connectivity/openssl/openssl_1.1.0h.bb | 12 +++++++++++-
>>  1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb b/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
>> index c5de085521..7af527ca31 100644
>> --- a/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
>> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
>> @@ -158,12 +158,22 @@ do_install_ptest() {
>>          sed -i 's/$target{shared_extension_simple}/".so.ptest"/' ${D}${PTEST_PATH}/test/recipes/90-test_shlibload.t
>>  }
>>
>> -PACKAGES =+ "${PN}-engines"
>> +PACKAGES =+ "libcrypto libssl ${PN}-misc ${PN}-engines openssl-conf"
>>
>> +FILES_libcrypto = "${libdir}/libcrypto${SOLIBS}"
>> +FILES_libssl = "${libdir}/libssl${SOLIBS}"
>>  FILES_${PN} =+ "${libdir}/ssl-1.1/*"
>>  FILES_${PN}_append_class-nativesdk = " ${SDKPATHNATIVE}/environment-setup.d/openssl.sh"
>>  FILES_${PN}-engines = "${libdir}/engines-1.1"
>>
>> +FILES_${PN}-misc = "${libdir}/ssl-1.1/misc"
>> +RDEPENDS_${PN}-misc = "${@bb.utils.filter('PACKAGECONFIG', 'perl', d)}"
>
> There is no "perl" PACKAGECONFIG in the openssl 1.1 recipe (there are
> no PACKAGECONFIG options at all...).
>
>> +
>> +FILES_openssl-conf = "${libdir}/ssl-1.1/openssl.cnf"
>> +CONFFILES_openssl-conf = "${libdir}/ssl-1.1/openssl.cnf"
>> +RRECOMMENDS_libcrypto += "openssl-conf"
>> +
>> +RDEPENDS_${PN}-bin = "perl"
>>  RDEPENDS_${PN}-ptest += "perl-module-file-spec-functions bash python"
>>
>>  BBCLASSEXTEND = "native nativesdk"
>> --
>> 2.11.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core