[OE-core] [PATCH 4/9] dos2unix.bbclass: Move to oe-core

[Richard Purdie]

On Mon, 2018-08-20 at 11:23 +0200, Martin Hundebøll wrote:
> Hi Khem,
> 
> On 19/08/2018 19.23, Khem Raj wrote:
> > - Import from meta-oe layer
> > 
> > - This is useful for many packages where CR-LF
> >    needs to be adjusted, many recipes depend on it
> >    e.g. meta-multimedia libebml and so on.
> > 
> > Signed-off-by: Khem Raj <raj.khem at gmail.com>
> > ---
> >   meta/classes/dos2unix.bbclass | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >   create mode 100644 meta/classes/dos2unix.bbclass
> > 
> > diff --git a/meta/classes/dos2unix.bbclass
> > b/meta/classes/dos2unix.bbclass
> > new file mode 100644
> > index 0000000000..3fc17e2196
> > --- /dev/null
> > +++ b/meta/classes/dos2unix.bbclass
> > @@ -0,0 +1,14 @@
> > +# Class for use to convert all CRLF line terminators to LF
> > +# provided that some projects are being developed/maintained
> > +# on Windows so they have different line terminators(CRLF) vs
> > +# on Linux(LF), which can cause annoying patching errors during
> > +# git push/checkout processes.
> > +
> > +do_convert_crlf_to_lf[depends] += "dos2unix-
> > native:do_populate_sysroot"
> 
> Shouldn't the dos2unix recipe live in oe-core also, when a class
> depends upon it?

Not necessarily, we do have a number of core classes which aren't
directly used in OE-Core but are needed by many layers and having a
common copy makes sense.

I'd agree it is good to try and have something which tests them though.

Cheers,

Richard