[OE-core] [PATCH] busybox: Add a dependency on virtual/crypt

[Khem Raj]

On Mon, Aug 20, 2018 at 2:45 AM Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
>
> On Mon, 2018-08-20 at 04:46 +0200, Peter Kjellerstedt wrote:
> > busybox needs crypt() if CONFIG_USE_BB_CRYPT is not defined.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
> > ---
> >  meta/recipes-core/busybox/busybox.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-
> > core/busybox/busybox.inc
> > index 8c6dbbaf9b..a8ba10d21c 100644
> > --- a/meta/recipes-core/busybox/busybox.inc
> > +++ b/meta/recipes-core/busybox/busybox.inc
> > @@ -3,7 +3,8 @@ DESCRIPTION = "BusyBox combines tiny versions of many
> > common UNIX utilities into
> >  HOMEPAGE = "http://www.busybox.net"
> >  BUGTRACKER = "https://bugs.busybox.net/"
> >
> > -DEPENDS += "kern-tools-native"
> > +# Depend on virtual/crypt in case CONFIG_USE_BB_CRYPT is not defined
> > +DEPENDS += "kern-tools-native virtual/crypt"
>
> I'm not a bug fan of adding dependencies which might not be needed. How
> common is CONFIG_USE_BB_CRYPT not being defined? I assume that isn't
> our default config?

yes perhaps it should be packageconfig

>
> Cheers,
>
> Richard
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core