[OE-core] [oe-core][PATCH] runtime selftest: hw breakpoint case correct syntax
Randy MacLeod
randy.macleod at windriver.com
Tue Aug 21 15:30:16 UTC 2018
On 08/21/2018 02:23 AM, Hongzhi.Song wrote:
> 1. There is a wrong syntax.
Usually the word syntax refers to code and grammar refers
to English phrasing (but it's a weird language and the
rules are sometimes ignored).
> 2. Since last commit has exclude the arm64, so remove arm64.
What last commit? Please write the log help people who
have not been working on the patch.
See:
https://chris.beams.io/posts/git-commit/
for guidelines.
Something like:
Subject:
runtime selftest: hw breakpoint drop arm64, correct grammar
Improve grammar in skip test output.
Do not run the test for arm64 because commit XXXXXX did YYYYY.
Thanks!
../Randy
>
> Signed-off-by: Hongzhi.Song <hongzhi.song at windriver.com>
> ---
> meta/lib/oeqa/runtime/cases/ksample.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/lib/oeqa/runtime/cases/ksample.py b/meta/lib/oeqa/runtime/cases/ksample.py
> index eb8713351a..0e00cdeeb6 100644
> --- a/meta/lib/oeqa/runtime/cases/ksample.py
> +++ b/meta/lib/oeqa/runtime/cases/ksample.py
> @@ -166,9 +166,9 @@ class KSampleTest(KSample):
> def test_hw_breakpoint_example(self):
> # check arch
> status, output = self.target.run("uname -m")
> - result = ("x86" in output) or ("aarch64" in output)
> + result = "x86" in output
> if not result:
> - self.skipTest("the arch doesn't support hw breakpoint" % output)
> + self.skipTest("the arch %s doesn't support hw breakpoint" % output)
> # check config
> self.check_config("CONFIG_KALLSYMS_ALL")
> # make sure if module exists
>
--
# Randy MacLeod
# Wind River Linux
More information about the Openembedded-core
mailing list