[OE-core] [PATCH] kernel: yocto: Add dependency on do_prepare_recipe_sysroot

[Bruce Ashfield]

On 08/22/2018 09:40 AM, Lukasz Majewski wrote:
> Without this patch it happens that do_populate_recipe_sysroot is called
> just before do_compile (on multi core build machines).
> This is way too late as the .config generated in do_kernel_configme()
> is already broken.
> 
> The problem is that do_kernel_configme() calls native's merge_config.sh
> script which may call bison and arm-linux-*-gcc to compile kconfig
> infrastructure to create base .config
> (scripts/kconfig/conf  --allnoconfig Kconfig.)
> 
> It turns out that we only got above binaries after do_prepare_recipe_sysroot()
> is called.
> If those binaries are not available, the merge_config.sh do not generate
> base .config and without any error produces malfunctioned .config.
> The build process continues and as a result broken kernel is compiled.
> 
> To reproduce:
> 
> bitbake -c cleansstate virtual/kernel
> bitbake -c kernel_metadata -v virtual/kernel
> bitbake -c do_kernel_configme -v virtual/kernel
> (one shall see broken .config in ${B}/.config)
> bitbake -c do_populate_sysroot -v virtual/kernel
> bitbake -c do_compile -v virtual/kernel
> 
> (Poky) SHA1: bb91b2ae3ee5cf108aa2f9b78abb14d5aa00831d
> 
> Signed-off-by: Lukasz Majewski <lukma at denx.de>
> ---
>   meta/classes/kernel-yocto.bbclass | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index 4ac3a39e47..19a3f2bc46 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -276,6 +276,7 @@ do_kernel_metadata[depends] = "kern-tools-native:do_populate_sysroot"
>   do_validate_branches[depends] = "kern-tools-native:do_populate_sysroot"
>   
>   do_kernel_configme[dirs] += "${S} ${B}"
> +do_kernel_configme[depends] += "virtual/kernel:do_prepare_recipe_sysroot"

On a closer look .. what branch is this from ? We already have a
change that triggered breakage on 4.17+ that should fix this.

i.e. commit ff1bdd75d50f0ebac3d599e461685ace29559a82 in oe-core, adds:

----------

  do_kernel_metadata[depends] = "kern-tools-native:do_populate_sysroot"
  do_validate_branches[depends] = "kern-tools-native:do_populate_sysroot"

+do_kernel_configme[depends] += 
"virtual/${TARGET_PREFIX}binutils:do_populate_sysroot"
+do_kernel_configme[depends] += 
"virtual/${TARGET_PREFIX}gcc:do_populate_sysroot"
+do_kernel_configme[depends] += "bc-native:do_populate_sysroot 
bison-native:do_populate_sysroot"
  do_kernel_configme[dirs] += "${S} ${B}"
  do_kernel_configme() {

----------

Which I don't see in the context of your patch.

Bruce

>   do_kernel_configme() {
>   	set +e
>   
>