[OE-core] [PATCH] cmake: add CMAKE_SYSROOT to generated toolchain file

[Khem Raj]

On Fri, Aug 24, 2018 at 9:17 AM <Mikko.Rapeli at bmw.de> wrote:
>
> On Fri, Aug 24, 2018 at 08:51:42AM -0700, Khem Raj wrote:
> > On Fri, Aug 24, 2018 at 8:48 AM <Mikko.Rapeli at bmw.de> wrote:
> > > So to me it looks like using SYSTEM with target_include_directories()
> > > is no longer possible with CMake and gcc > 6:
> > >
> > >
> > > https://cmake.org/cmake/help/v3.10/command/target_include_directories.html?highlight=target_include_directories
> > >
> >
> > That’s right there is a patch I did  in WebKitgtk recipe in Oe Core you
> > might want to include similar fixes for this package the patch actually it
> > a workaround but then I also think using isystem in apps is a bad idea
>
> Yes, I tend to agree, but developers have used this to silence compiler
> warnings from system header files.
>
> In a few cases I saw that there were no longer any warnings coming from the
> headers but in some others there were.
>

Unlike olden days, cross gcc compiler now a days knows about its
system headers and adds them implicitly with right options
so doing this include dance manually is not useful. Let compiler
decide to do the needed
for system headers, one must just specify --sysroot and let it handle
everything from sysroot.

> Any other ideas how to suppress compiler wanings from system headers?
>

what kind of warnings do you see ?

> -Mikko