[OE-core] [PATCH 3/3] image_types_wic: Add variable WIC_EXTENSION

[Richard Purdie]

On Mon, 2018-08-27 at 17:31 +0300, Alexandru Vasiu wrote:
> Used to specify what extention will have the image file which
> is created using wic. The default value is wic. For creating an
> ISO image, WIC_EXTENSION will be iso.
> 
> Signed-off-by: Alexandru Vasiu <alexandru.vasiu at ni.com>
> ---
>  meta/classes/image.bbclass           | 2 ++
>  meta/classes/image_types_wic.bbclass | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 024d2d4c96..c6833a6770 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -607,6 +607,8 @@ python create_symlinks() {
>      if not link_name:
>          return
>      for type in subimages:
> +        if type == 'wic':
> +            type = d.getVar('WIC_EXTENSION')
>          dst = os.path.join(deploy_dir, link_name + "." + type)
>          src = img_name + imgsuffix + type
>          if os.path.exists(os.path.join(deploy_dir, src)):

This is hardcoding an image type specific issue into common code. I
really want to avoid doing that.

In the past I started the process of trying to untangle the spaghetti
we had in image.bbclass and abstract it into common building blocks.
The hope was to eventually have proper APIs around this.

I never really got back to do further rounds of cleanup/improvement to
get to that goal but the more image type specific pieces we add back
in, the harder it will make those goals and the less maintainable the
coed will become.

So is there some other way we can handle this. It looks like we don't
even use this iso mode in OE-Core which is bad from a testing
perspective too? I don't see WIC_EXTENSION being set to iso anywhere?

Cheers,

Richard