[OE-core] [PATCH] classes/waf: Fix builds when B != S

[Joshua Watt]

On Fri, Nov 30, 2018, 6:01 PM Joshua Watt <jpewhacker at gmail.com wrote:

>
>
> On Fri, Nov 30, 2018, 5:00 PM Burton, Ross <ross.burton at intel.com wrote:
>
>> On Fri, 30 Nov 2018 at 21:56, Joshua Watt <jpewhacker at gmail.com> wrote:
>> > +B = "${WORKDIR}/${BPN}-${PV}"
>>
>> That's the default, so redundant.
>>
>> Does waf support out-of-tree builds sufficiently well that we can
>> default  - or even mandate - out of tree?  i.e. follow meson and
>> cmake, and just set B=$WORKDIR/build in the class.
>>
>
> Yes. This patch already does that by adding "-o ${B}" in do_configure. I
> will change it to ${WORKDIR}/build. Out if curiosity, why is that preferred
> over ${WORKDIR}/${BPN}-${PV} ?
>

Hah, right. {WORKDIR}/${BPN}-${PV} is also the default value for ${S}, so
setting to ${WORKDIR}/build ensures they are different, which we want/need
for waf.


>> Ross
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20181130/485dfed3/attachment.html>