[OE-core] [PATCH 1/2] pulseaudio: improve reproducibility

[Tanu Kaskinen]

On Wed, 2018-12-05 at 10:11 +0800, Hongxu Jia wrote:
> Remove build host paths from generated binaries, the modification
> is harmless for build time compiling and runtime executing.
> 
> [YOCTO #12638]
> 
> Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
> ---
>  .../pulseaudio/0001-improve-reproducibility.patch  | 50 ++++++++++++++++++++++
>  .../pulseaudio/pulseaudio_12.2.bb                  |  1 +
>  2 files changed, 51 insertions(+)
>  create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-improve-reproducibility.patch
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-improve-reproducibility.patch b/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-improve-reproducibility.patch
> new file mode 100644
> index 0000000..b13adb2
> --- /dev/null
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-improve-reproducibility.patch
> @@ -0,0 +1,50 @@
> +From e03d1d77471ee16c149590dd97085cf54be1e261 Mon Sep 17 00:00:00 2001
> +From: Hongxu Jia <hongxu.jia at windriver.com>
> +Date: Tue, 4 Dec 2018 16:29:18 +0800
> +Subject: [PATCH] improve reproducibility
> +
> +- Do not define PA_CFLAGS with $CFLAGS which contains build host path,
> +  macro PA_CFLAGS is used for debug log, the modification is harmless;
> +
> +- Tweak definition of PA_BUILDDIR and PA_SRCDIR with relative directory,
> +  it is also harmless;

I believe changing PA_BUILDDIR and PA_SRCDIR to relative directories
actually breaks the things that use those definitions. PA_BUILDDIR is
compared to the /proc/self/exe symlink target, which is an absolute
path. The definitions are needed when running PulseAudio from the
source tree without installing, so the breakage doesn't really matter
in OE, but it would be better to set them to values that clearly don't
work rather than something that looks like is intended to work but
actually doesn't.

-- 
Tanu

https://www.patreon.com/tanuk
https://liberapay.com/tanuk