[OE-core] [PATCH 6/6] gcc-runtime: Add missing libc dependency

[Khem Raj]

On Tue, Dec 18, 2018 at 4:05 AM Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
>
> For reasons lost in the depths of time, perhaps performane related,
> we only have a dependency on libc at packaging time. This is too late,
> as demonstrated by a recent build failure on non-IA builds where
> the glibc 2.29 upgrade had been removed from the build:
>
> ld: recipe-sysroot/usr/lib/../lib/libstdc++.so: undefined reference to `log at GLIBC_2.29'
>
> libstdc++ should have been rebuilt but had not as the dependency
> wasn't present.
>
> Add the missing dependency to avoid this problem (and drop the other
> form of dependency which is no longer needed).
>

this is good find. lgtm

> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> ---
>  meta/recipes-devtools/gcc/gcc-runtime.inc | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime.inc b/meta/recipes-devtools/gcc/gcc-runtime.inc
> index 9e7e7c5b3d6..95153da20cd 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-runtime.inc
> @@ -128,7 +128,7 @@ do_install_append_class-target () {
>  }
>
>  INHIBIT_DEFAULT_DEPS = "1"
> -DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++ libgcc"
> +DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++ libgcc virtual/${MLPREFIX}libc"
>  PROVIDES = "virtual/${TARGET_PREFIX}compilerlibs"
>
>  BBCLASSEXTEND = "nativesdk"
> @@ -288,7 +288,3 @@ FILES_libmpx-dev = "\
>  SUMMARY_libmpx-dev = "Intel Memory Protection Extension library - development files"
>  FILES_libmpx-staticdev = "${libdir}/libmpx.a ${libdir}/libmpxwrappers.a"
>  SUMMARY_libmpx-staticdev = "Intel Memory Protection Extension library - static development files"
> -
> -do_package_write_ipk[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
> -do_package_write_deb[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
> -do_package_write_rpm[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
> --
> 2.19.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core