[OE-core] [PATCH v2 08/17] icecc-create-env: Archive directory
Joshua Watt
jpewhacker at gmail.com
Mon Feb 12 16:52:03 UTC 2018
Taring up the toolchain is now done by adding the entire working
directory, instead of listing all the files individually. This is done
because the list of files may contain ".." entries, which tar does not
like and strips out, resulting in bad archives. This should result in an
identical archive to what was previously generated.
In addition, symbolic links are no longer dereferenced when creating the
archive, as they are purposely included to provide alternate names for
files
Signed-off-by: Joshua Watt <JPEWhacker at gmail.com>
---
.../icecc-create-env/icecc-create-env/icecc-create-env | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/icecc-create-env/icecc-create-env/icecc-create-env b/meta/recipes-devtools/icecc-create-env/icecc-create-env/icecc-create-env
index 0791bd54b27..426b093d91c 100755
--- a/meta/recipes-devtools/icecc-create-env/icecc-create-env/icecc-create-env
+++ b/meta/recipes-devtools/icecc-create-env/icecc-create-env/icecc-create-env
@@ -256,7 +256,11 @@ if test -z "$silent"; then
fi
cd $tempdir
-tar -czhf "$mydir/$archive_name" $target_files || {
+# Add everything in the temp directory. Tar doesn't like to be given files with
+# ".." in them, which frequently happens in $target_files, and will strip off
+# the path prefix past the offending "..". This makes the archive generate
+# incorrectly
+tar -czf "$mydir/$archive_name" . || {
if test -z "$silent"; then
echo "Couldn't create archive"
fi
--
2.14.3
More information about the Openembedded-core
mailing list