[OE-core] [PATCH] license.bbclass: set do_bootimg recrdeptask on do_populate_lic

Ming Liu liu.ming50 at gmail.com
Thu Feb 15 14:11:03 UTC 2018


Hi, Richard:

I observed this issue on rocko branch, but I think upstream also needs it.
Since even recrdepends handling had been changed in bitbake, the problem
here is the "recrdepends" is missing between do_bootimg and do_populate_lic,
actually there was a bug record for it, see:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9446, but the fix only
considered the missing recrdepends of do_image, but looking
into get_deployed_dependencies->get_boot_dependencies, the do_bootimg also
needs a similar fix.

//Ming Liu

2018-02-15 14:34 GMT+01:00 Richard Purdie <
richard.purdie at linuxfoundation.org>:

> On Thu, 2018-02-15 at 13:49 +0100, liu.ming50 at gmail.com wrote:
> > From: Ming Liu <liu.ming50 at gmail.com>
> >
> > This is needed since the license_deployed_manifest task is referring
> > the deployed licenses of the depends of do_bootimg task.
> >
> > Signed-off-by: Ming Liu <liu.ming50 at gmail.com>
> > ---
> >  meta/classes/license.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/classes/license.bbclass
> > b/meta/classes/license.bbclass
> > index d353110..10d2279 100644
> > --- a/meta/classes/license.bbclass
> > +++ b/meta/classes/license.bbclass
> > @@ -679,6 +679,7 @@ do_rootfs[recrdeptask] += "do_populate_lic"
> >
> >  IMAGE_POSTPROCESS_COMMAND_prepend = "write_deploy_manifest; "
> >  do_image[recrdeptask] += "do_populate_lic"
> > +do_bootimg[recrdeptask] += "do_populate_lic"
> >
> >  python do_populate_lic_setscene () {
> >      sstate_setscene(d)
>
> How old is this patch?
>
> The recrdepends handling in bitbake changed recently and these kind of
> older issues may have been a bitbake bug. Can you describe a test
> scenario and check if master still needs this "fix"?
>
> Cheers,
>
> Richard
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180215/3bb2c622/attachment-0002.html>


More information about the Openembedded-core mailing list