[OE-core] [OE-Core][PATCHv2 1/1] wic: argparse now used for help functionality.

[Paul Eggleton]

Hi Amber

On Wednesday, 31 January 2018 07:24:42 NZDT anelliot wrote:
> The wic help output formally consisted of manually created strings mixed
> with argparse,
> which was unformatted and unusable. This fix cleans up the help messages,
> rewrites help
> functionality to use argparse, and adds functionality to show information
> for plugins (similar to canned images).

So after an inexcusably long delay on my part, I looked at this today. The 
move to argparse is a definite improvement, however I do have the following 
concerns:

* "wic help" no longer seems to accept an argument i.e. the command to show 
help for. I'll grant that it's not really needed if you know you can run wic 
<command> --help instead, but then we do still provide it so it seems to me it 
ought to work in a similar manner to how it did previously. I looked elsewhere 
and it seems "git help <command>" works that way too, FWIW.

* What's with the apparent change from "help" to "info"? That's not mentioned 
in the commit message.

* Some of the tests seem to be switched around in purpose but keep the same 
ID; some switch from --help to -h which should be the same thing. It's not 
clear to me what's been done there and why. I can understand the tests need 
updating as a result of the changes, but this seems to do more than that, and 
there's no explanation in the commit message.

* Newline should not be dropped at the end

(It could be that this would benefit from being split up, i.e. do the argparse 
switchover in one commit and then other changes in subsequent commits, but I'm 
willing to be convinced otherwise.)

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre