[OE-core] [PATCH] gettext: fix PACKAGECONFIGs

[Burton, Ross]

Yeah, I managed to typo.  Latest ross/mut has a new version.

Ross

On 23 January 2018 at 22:29, Martin Jansa <martin.jansa at gmail.com> wrote:

> The
> --without-included-libunistring=
> change there
>
> -PACKAGECONFIG[libunistring] = "--without-included-libunistri
> ng,--with-included-libunistring,libunistring"
> +PACKAGECONFIG[libunistring] = "--without-included-libunistri
> ng=${STAGING_LIBDIR}/..,--with-included-libunistring,libunistring"
>
> looks really strange and indeed it fails:
>
> | configure: error: invalid package name: included-libunistring=/OE/BUIL
> D/work/qemux86-oe-linux/gettext/0.19.8.1-r0/recipe-sysroot/usr/lib/..
>
> After removing this part and keeping only the added .patch I got the same
> error as before:
> ERROR: gettext-0.19.8.1-r0 do_configure: This autoconf log indicates
> errors, it looked at host include and/or library paths while determining
> system capabilities.
> Rerun configure task after fixing this.
>
> 0.19.8.1-r0/build/gettext-tools/config.log:cc1: warning: include location
> "/usr/include/glib-2.0" is unsafe for cross-compilation
> [-Wpoison-system-directories]
>
>
>
> On Tue, Jan 23, 2018 at 1:58 AM, Burton, Ross <ross.burton at intel.com>
> wrote:
>
>> Hi Martin,
>>
>> I've a patch at the top of poky-contrib:ross/mut which hopefully fixes
>> this.  It's a bit more invasive than I'd like but this is gettext and I'm
>> still at least partially sane, so that's a win as far as I'm concerned.
>>
>> I've a build running now but touching gettext causes a rebuild of the
>> world so I'm going to bed whist it runs.  Would you be able to test it in
>> your environment too?
>>
>> Cheers,
>> Ross
>>
>> On 22 January 2018 at 19:46, Burton, Ross <ross.burton at intel.com> wrote:
>>
>>> This is causing QA errors:
>>>
>>> ERROR: gettext-0.19.8.1-r0 do_package_qa: QA Issue: gettext:
>>> /work/corei7-64-poky-linux/gettext/0.19.8.1-r0/packages-spli
>>> t/gettext/usr/lib/gettext/hostname contains probably-redundant RPATH
>>> /usr/lib/../lib
>>> gettext: /work/corei7-64-poky-linux/gettext/0.19.8.1-r0/packages-spli
>>> t/gettext/usr/lib/gettext/urlget contains probably-redundant RPATH
>>> /usr/lib/../lib
>>> gettext: /work/corei7-64-poky-linux/gettext/0.19.8.1-r0/packages-spli
>>> t/gettext/usr/lib/gettext/cldr-plurals contains probably-redundant
>>> RPATH /usr/lib/../lib
>>> gettext: /work/corei7-64-poky-linux/gettext/0.19.8.1-r0/packages-spli
>>> t/gettext/usr/bin/recode-sr-latin contains probably-redundant RPATH
>>> /usr/lib/../lib [useless-rpaths]
>>>
>>> Ross
>>>
>>> On 22 January 2018 at 10:52, Martin Jansa <martin.jansa at gmail.com>
>>> wrote:
>>>
>>>> * add --with-*-prefix variables to prevent configure trying to search
>>>> in host paths
>>>> * fixes:
>>>>   ERROR: This autoconf log indicates errors, it looked at host include
>>>> and/or library paths while determining system capabilities.
>>>>   gettext/0.19.8.1-r0/build/gettext-tools/config.log:cc1: warning:
>>>> include location /usr/include/glib-2.0 is unsafe for cross-compilation
>>>> [-Wpoison-system-directories]
>>>>
>>>> * not sure if it's worth adding other prefixes for curses related
>>>> PACKAGECONFIG
>>>>   PACKAGECONFIG[msgcat-curses] = "--with-libncurses-prefix=${ST
>>>> AGING_LIBDIR}/..,--disable-curses,ncurses,"
>>>>
>>>>   --with-libncurses-prefix[=DIR]  search for PACKLIBS in DIR/include
>>>> and DIR/lib
>>>>   --without-libncurses-prefix     don't search for PACKLIBS in
>>>> includedir and libdir
>>>>   --with-libxcurses-prefix[=DIR]  search for PACKLIBS in DIR/include
>>>> and DIR/lib
>>>>   --without-libxcurses-prefix     don't search for PACKLIBS in
>>>> includedir and libdir
>>>>   --with-libcurses-prefix[=DIR]  search for PACKLIBS in DIR/include and
>>>> DIR/lib
>>>>   --without-libcurses-prefix     don't search for PACKLIBS in
>>>> includedir and libdir
>>>>
>>>> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
>>>> ---
>>>>  meta/recipes-core/gettext/gettext_0.19.8.1.bb | 8 ++++----
>>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-core/gettext/gettext_0.19.8.1.bb
>>>> b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
>>>> index 97083c0da2..8a8a34cca8 100644
>>>> --- a/meta/recipes-core/gettext/gettext_0.19.8.1.bb
>>>> +++ b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
>>>> @@ -43,10 +43,10 @@ PACKAGECONFIG ??= "croco glib libxml libunistring"
>>>>  PACKAGECONFIG_class-native = ""
>>>>  PACKAGECONFIG_class-nativesdk = ""
>>>>
>>>> -PACKAGECONFIG[croco] = "--without-included-libcroco,-
>>>> -with-included-libcroco,libcroco"
>>>> -PACKAGECONFIG[glib] = "--without-included-glib,--wit
>>>> h-included-glib,glib-2.0"
>>>> -PACKAGECONFIG[libxml] = "--without-included-libxml,--w
>>>> ith-included-libxml,libxml2"
>>>> -PACKAGECONFIG[libunistring] = "--without-included-libunistri
>>>> ng,--with-included-libunistring,libunistring"
>>>> +PACKAGECONFIG[croco] = "--with-libcroco-0.6-prefix=${STAGING_LIBDIR}/..
>>>> --without-included-libcroco,--with-included-libcroco,libcroco"
>>>> +PACKAGECONFIG[glib] = "--with-libglib-2.0-prefix=${STAGING_LIBDIR}/..
>>>> --without-included-glib,--with-included-glib,glib-2.0"
>>>> +PACKAGECONFIG[libxml] = "--with-libxml2-prefix=${STAGING_LIBDIR}/..
>>>> --without-included-libxml,--with-included-libxml,libxml2"
>>>> +PACKAGECONFIG[libunistring] = "--with-libunistring-prefix=${STAGING_LIBDIR}/..
>>>> --without-included-libunistring,--with-included-libunistring
>>>> ,libunistring"
>>>>  PACKAGECONFIG[msgcat-curses] = "--with-libncurses-prefix=${ST
>>>> AGING_LIBDIR}/..,--disable-curses,ncurses,"
>>>>
>>>>  acpaths = '-I ${S}/gettext-runtime/m4 \
>>>> --
>>>> 2.15.1
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core at lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180123/7bca4b1c/attachment-0002.html>