[OE-core] [PATCH] waf.bbclass: check that waf exists before trying to execute it

[Martin Jansa]

+Andreas who added waf inherit in jack in:
commit 0f8f1973e229a0799098bc2334416fec8c608b50
Author: Andreas Müller <schnitzeltony at googlemail.com>
Date:   Sat Oct 8 12:03:32 2016 +0200

    jack: swap to jack2

+Bian who added waf samba in:
commit 962e346df99696a10657a2ea7b2166dfaf290289
Author: Bian Naimeng <biannm at cn.fujitsu.com>
Date:   Tue Jun 16 14:18:25 2015 +0900

    waf-samba: add new class

    waf-samba is a build system used by samba related software

+Joe and Joe and who maintains samba and related recipes + meta-networking


On Tue, Jan 30, 2018 at 1:03 PM, Burton, Ross <ross.burton at intel.com> wrote:

> Why would they do that?  Shouldn't it be a fatal bug if waf isn't found?
>
> On 30 January 2018 at 08:30, Martin Jansa <martin.jansa at gmail.com> wrote:
>
>> * there are some recipes like jack and other which inherit waf-samba
>> which inherits waf, but they don't use waf for configure, strange isn't
>> it?
>>
>> * fixes:
>> WARNING: libldb-1.1.29-r0 do_configure: Unable to execute waf --version,
>> exit code 127. Assuming waf version without bindir/libdir support.
>> WARNING: samba-4.6.7-r0 do_configure: Unable to execute waf --version,
>> exit code 127. Assuming waf version without bindir/libdir support.
>> WARNING: libtalloc-2.1.9-r0 do_configure: Unable to execute waf
>> --version, exit code 127. Assuming waf version without bindir/libdir
>> support.
>> WARNING: jack-1.9.10+gitAUTOINC+2d1d323505-r0 do_configure: Unable to
>> execute waf --version, exit code 1. Assuming waf version without
>> bindir/libdir support.
>> WARNING: libtevent-0.9.31-r0 do_configure: Unable to execute waf
>> --version, exit code 127. Assuming waf version without bindir/libdir
>> support.
>> WARNING: libtdb-1.3.14-r0 do_configure: Unable to execute waf --version,
>> exit code 127. Assuming waf version without bindir/libdir support.
>>
>> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
>> ---
>>  meta/classes/waf.bbclass | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/classes/waf.bbclass b/meta/classes/waf.bbclass
>> index c3e744e5de..eec4d9496d 100644
>> --- a/meta/classes/waf.bbclass
>> +++ b/meta/classes/waf.bbclass
>> @@ -29,6 +29,9 @@ python waf_preconfigure() {
>>      from distutils.version import StrictVersion
>>      srcsubdir = d.getVar('S')
>>      wafbin = os.path.join(srcsubdir, 'waf')
>> +    if not os.path.isfile(wafbin):
>> +        bb.note("%s doesn't exist, cannot check whether it supports
>> --bindir/--libdir" % wafbin)
>> +        return
>>      status, result = oe.utils.getstatusoutput(wafbin + " --version")
>>      if status != 0:
>>          bb.warn("Unable to execute waf --version, exit code %d. Assuming
>> waf version without bindir/libdir support." % status)
>> --
>> 2.15.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180130/9433c8f9/attachment-0002.html>