[OE-core] [PATCH] bitbake.conf: Add comm to HOSTTOOLS

Manjukumar Harthikote Matha MANJUKUM at xilinx.com
Tue Jan 30 16:34:05 UTC 2018



> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org
> [mailto:openembedded-core-bounces at lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: Monday, January 29, 2018 11:07 PM
> To: openembedded-core at lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] bitbake.conf: Add comm to HOSTTOOLS
> 
> 
> 
> On 1/29/18 10:38 PM, Alexander Kanavin wrote:
> > On 01/29/2018 07:47 PM, Niko Mauno wrote:
> >> This mitigates following issues during u-boot do_compile() step --
> >> otherwise, if comm is not available, they are quietly ignored:
> >>
> >>    .../scripts/check-config.sh: line 33: comm: command not found
> >>    .../scripts/check-config.sh: line 39: comm: command not found
> >>
> >> Since 'comm' is provided by coreutils package, adding it to HOSTTOOLS
> >> was considered a lower impact fix compared to adding coreutils-native
> >> buildtime dependency to u-boot recipe.
> >
> > I disagree. Expanding HOSTTOOLS just to cater to the needs of a single
> > recipe is not optimal, IMO.
>
> alternative are
> build time dep on coreutils-native.

This works, tested it however u-boot now will depend on coreutils-native.

> fix uboot script to not use comm
> do not invoke check-config.sh at all.
> 
This might not be an option for us :)

> none of them are any better.
> 

Agree with Khem here, if it is not in HOSTTOOLS, it will trickle down to coreutils-native till u-boot script gets patched.   

Thanks,
Manju


More information about the Openembedded-core mailing list