[OE-core] [PATCH] security_flags.inc: Use SECURITY_X_LDFLAGS

Tom Rini trini at konsulko.com
Wed Jan 31 17:37:57 UTC 2018


We need to ensure that all xorg modules are linked with
SECURITY_X_LDFLAGS to ensure that they will be able to resolve their run
time dependencies.  Replace the incomplete list here with globs for both
video and input modules.

Cc: Khem Raj <raj.khem at gmail.com>
Signed-off-by: Tom Rini <trini at konsulko.com>
---
I admit that I'm not sure if this, or an explicit list of all of the
modules in both oe-core (we are missing some today) and
meta-openembedded (or per-recipe updates there) would be best.  I'm
starting with a patch that does a glob as that will cover what we have
today as well as in the future.
---
 meta/conf/distro/include/security_flags.inc | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/meta/conf/distro/include/security_flags.inc b/meta/conf/distro/include/security_flags.inc
index 7ea1049edff8..732972e85136 100644
--- a/meta/conf/distro/include/security_flags.inc
+++ b/meta/conf/distro/include/security_flags.inc
@@ -59,12 +59,9 @@ TARGET_LDFLAGS_append_class-target = " ${SECURITY_LDFLAGS}"
 SECURITY_LDFLAGS_remove_pn-gcc-runtime = "-fstack-protector-strong"
 SECURITY_LDFLAGS_remove_pn-glibc = "-fstack-protector-strong"
 SECURITY_LDFLAGS_remove_pn-glibc-initial = "-fstack-protector-strong"
-SECURITY_LDFLAGS_pn-xf86-video-fbdev = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-intel = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-omapfb = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-omap = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-vesa = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-vmware = "${SECURITY_X_LDFLAGS}"
+# All xorg module drivers need to be linked this way
+SECURITY_LDFLAGS_pn-xf86-video-% = "${SECURITY_X_LDFLAGS}"
+SECURITY_LDFLAGS_pn-xf86-input-% = "${SECURITY_X_LDFLAGS}"
 SECURITY_LDFLAGS_pn-xserver-xorg = "${SECURITY_X_LDFLAGS}"
 
 TARGET_CC_ARCH_append_pn-binutils = " ${SELECTED_OPTIMIZATION}"
-- 
2.7.4




More information about the Openembedded-core mailing list