[OE-core] [PATCH] Fix & extend recommendations for license packages.

Peter Kjellerstedt peter.kjellerstedt at axis.com
Sun Jul 1 17:40:58 UTC 2018


> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org
> [mailto:openembedded-core-bounces at lists.openembedded.org] On Behalf Of
> Alp Özmert
> Sent: den 29 juni 2018 17:41
> To: openembedded-core at lists.openembedded.org
> Subject: [OE-core] [PATCH] Fix & extend recommendations for license
> packages.
> 
> Changed package recommendations so that the license package of a
> recipe is recommended for all packages of a recipe instead of for one
> package given by the recipe name.
> 
> Pre-patch behaviour results in a missing recommendation when a recipe
> does not have a package with the same name.
> 
> Signed-off-by: Alp Özmert <info at ib-oezmert.de>
> ---
>  meta/classes/license.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/license.bbclass
> b/meta/classes/license.bbclass
> index 06dd4a8..79ea7ed 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -340,6 +340,7 @@ def add_package_and_files(d):
>          # first in PACKAGES to be sure that nothing else gets LICENSE_FILES_DIRECTORY
>          d.setVar('PACKAGES', "%s %s" % (pn_lic, packages))
>          d.setVar('FILES_' + pn_lic, files)
> +    for pn in packages.split():

You should avoid adding a recommendation of the ${PN}-lic package to 
itself if it happens to be listed in PACKAGES:

         if pn == pn_lic:
             continue

>          rrecommends_pn = d.getVar('RRECOMMENDS_' + pn)
>          if rrecommends_pn:
>              d.setVar('RRECOMMENDS_' + pn, "%s %s" % (pn_lic, rrecommends_pn))
> --
> 2.7.4

//Peter



More information about the Openembedded-core mailing list