[OE-core] [OE-Core][PATCH] openssh: Add dependency on ssh for sftp

[Alex Kiernan]

On Mon, Jul 2, 2018 at 3:55 PM Mike Looijmans <mike.looijmans at topic.nl> wrote:
>
> The sftp-server runs fine using dropbear as SSH backend, I'd expect the same
> to be true for the client. Isn't that the case, and will the sftp client only
> work with openssh's ssh?
>

Interesting question... I hadn't realised dropbear didn't have an sftp
client, but it's clearly a supported combination:

https://github.com/mkj/dropbear/blob/1656db9e58e7e8188e4ca27ae4892b14949c56a5/dbclient.1#L159

I'll amend the patch so it depends on ssh not ${PN}-ssh since both
dropbear and openssh provide that.

> On 01-07-18 12:33, Alex Kiernan wrote:
> > Add missing dependency on the ssh binary for the sftp client to avoid
> > failure at runtime if it's not been installed through another dependency
> > chain.
> >
> > Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
> > ---
> >
> >   meta/recipes-connectivity/openssh/openssh_7.7p1.bb | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-connectivity/openssh/openssh_7.7p1.bb b/meta/recipes-connectivity/openssh/openssh_7.7p1.bb
> > index b3da5f6..d147f43 100644
> > --- a/meta/recipes-connectivity/openssh/openssh_7.7p1.bb
> > +++ b/meta/recipes-connectivity/openssh/openssh_7.7p1.bb
> > @@ -146,6 +146,7 @@ FILES_${PN}-keygen = "${bindir}/ssh-keygen"
> >
> >   RDEPENDS_${PN} += "${PN}-scp ${PN}-ssh ${PN}-sshd ${PN}-keygen"
> >   RDEPENDS_${PN}-sshd += "${PN}-keygen ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam-plugin-keyinit pam-plugin-loginuid', '', d)}"
> > +RDEPENDS_${PN}-sftp += "${PN}-ssh"
> >   RDEPENDS_${PN}-ptest += "${PN}-sftp ${PN}-misc ${PN}-sftp-server make"
> >
> >   RPROVIDES_${PN}-ssh = "ssh"
> >
>
>
>
> Kind regards,
>
> Mike Looijmans
> System Expert
>
> TOPIC Products
> Materiaalweg 4, NL-5681 RJ Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> E-mail: mike.looijmans at topicproducts.com
> Website: www.topicproducts.com
>
> Please consider the environment before printing this e-mail
>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Alex Kiernan