[OE-core] [PATCH 1/2] openssl_1.1: avoid using += with an over-ride

[Andre McCurdy]

On Sat, Jul 7, 2018 at 1:52 AM, Alexander Kanavin
<alex.kanavin at gmail.com> wrote:
> We really need a QA warning for this issue. Nobody's going to remember
> what the correct way is. Can you look into it please?

It should be a parsing error, not a QA warning. If a feature of the
language is mistakenly used so often (100% of the time, as far as I
can tell) then we should just have the parser reject it.

> 2018-07-06 21:05 GMT+02:00 Andre McCurdy <armccurdy at gmail.com>:
>> Using += with an over-ride can be a source of confusion so try to
>> avoid the construct in core recipes.
>>
>> The current usage is incorrect and prevents the aarch64 and musl
>> specific config options from being active together.
>>
>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> ---
>>  meta/recipes-connectivity/openssl/openssl_1.1.0h.bb | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb b/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
>> index 94b75eb..ac2ad81 100644
>> --- a/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
>> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.0h.bb
>> @@ -122,12 +122,12 @@ do_configure () {
>>  #| engines/afalg/e_afalg.c:110:20: error: '__NR_eventfd' undeclared (first use in this function)
>>  #|      return syscall(__NR_eventfd, n);
>>  #|                     ^~~~~~~~~~~~
>> -EXTRA_OECONF_aarch64 += "no-afalgeng"
>> +EXTRA_OECONF_append_aarch64 = " no-afalgeng"
>>
>>  #| ./libcrypto.so: undefined reference to `getcontext'
>>  #| ./libcrypto.so: undefined reference to `setcontext'
>>  #| ./libcrypto.so: undefined reference to `makecontext'
>> -EXTRA_OECONF_libc-musl += "-DOPENSSL_NO_ASYNC"
>> +EXTRA_OECONF_append_libc-musl = " -DOPENSSL_NO_ASYNC"
>>
>>  do_install () {
>>          oe_runmake DESTDIR="${D}" MANDIR="${mandir}" MANSUFFIX=ssl install
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core