[OE-core] [PATCH] curl: disable C source code generator

[Andre McCurdy]

On Tue, Jul 17, 2018 at 11:37 AM, Khem Raj <raj.khem at gmail.com> wrote:
> On Tue, Jul 17, 2018 at 11:34 AM Andre McCurdy <armccurdy at gmail.com> wrote:
>>
>> On Tue, Jul 17, 2018 at 11:29 AM, Khem Raj <raj.khem at gmail.com> wrote:
>> > On Tue, Jul 17, 2018 at 11:07 AM Andre McCurdy <armccurdy at gmail.com> wrote:
>> >>
>> >> The --libcurl command line option causes curl to generate C source
>> >> code which, when compiled and linked with libcurl, creates a binary
>> >> which behaves in the same way as curl when run with the other options
>> >> passed on the curl command line.
>> >>
>> >>   https://curl.haxx.se/docs/manpage.html#--libcurl
>> >>
>> >> It's a development tool and not generally useful on the target,
>> >> especially if the target doesn't contain a toolchain etc.
>> >>
>> >
>> > probably better to have it controlled via packageconfig knob
>>
>> Really? Why?
>
> We do have people building SDKs for SBCs which ship development
> environments on targets and I believe
> it does not hurt to use packageconfig. Do you see downsides ?

It's an extremely obscure feature and I think PACKAGECONFIG options
should be reserved for stuff which we want to advertise as being
something a general user might want or need to control.

Of course there are targets which have toolchains, but I think the
chance that someone wants or needs to develop fixed function curl
replacement binaries on the target is close to zero.

>> >> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> >> ---
>> >>  meta/recipes-support/curl/curl_7.61.0.bb | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/meta/recipes-support/curl/curl_7.61.0.bb b/meta/recipes-support/curl/curl_7.61.0.bb
>> >> index 03d627e..cc983fd 100644
>> >> --- a/meta/recipes-support/curl/curl_7.61.0.bb
>> >> +++ b/meta/recipes-support/curl/curl_7.61.0.bb
>> >> @@ -49,6 +49,7 @@ PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
>> >>  PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
>> >>
>> >>  EXTRA_OECONF = " \
>> >> +    --disable-libcurl-option \
>> >>      --disable-ntlm-wb \
>> >>      --enable-crypto-auth \
>> >>      --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
>> >> --
>> >> 1.9.1
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-core mailing list
>> >> Openembedded-core at lists.openembedded.org
>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core