[OE-core] [PATCH] binutils : enable production of EFI binaries on x86-64

Burton, Ross ross.burton at intel.com
Wed Jul 25 09:55:53 UTC 2018


Yes, please just enable it as widely as possible.

Ross

On 25 July 2018 at 06:56, Khem Raj <raj.khem at gmail.com> wrote:
> On Tue, Jul 24, 2018 at 8:16 PM Christopher Clark
> <christopher.w.clark at gmail.com> wrote:
>>
>> From: Christopher Clark <christopher.clark6 at baesystems.com>
>>
>> When MACHINE_FEATURES includes "efi" and target is x86-64,
>> enable the linker to produce Portable Executables: EFI binaries.
>>
>> Supplies "--enable-targets=x86_64-pep" in EXTRA_OECONF.
>>
>> Enables building the EFI variant of the Xen hypervisor.
>>
>> Signed-off-by: Christopher Clark <christopher.clark6 at baesystems.com>
>> ---
>>  meta/recipes-devtools/binutils/binutils.inc | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
>> index 37813dd..eedcc7e 100644
>> --- a/meta/recipes-devtools/binutils/binutils.inc
>> +++ b/meta/recipes-devtools/binutils/binutils.inc
>> @@ -69,12 +69,15 @@ python do_package_prepend() {
>>
>>  B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
>>
>> +ENABLE_EFI_BINARIES_x86-64 = "--enable-targets=x86_64-pep"
>> +
>
>
>
>>  EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
>>                  --disable-werror \
>>                  --enable-deterministic-archives \
>>                  --enable-plugins \
>>                  ${LDGOLD} \
>> -                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
>> +                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
>> +                ${@bb.utils.contains('MACHINE_FEATURES', 'efi', '${ENABLE_EFI_BINARIES}', '', d)}"
>
> I think we should avoid using machine features rather enable this
> emulation unconditionally for efi enabled
> targets, which for now are arm/x86/x86_64/aarch64
>
>>
>>  LDGOLD_class-native = ""
>>  LDGOLD_class-crosssdk = ""
>> --
>> 2.7.4
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



More information about the Openembedded-core mailing list