[OE-core] [PATCH] classes/kernel-yocto: Cleanup getstatusoutput usage

Bruce Ashfield bruce.ashfield at gmail.com
Wed Jul 25 20:32:48 UTC 2018


On Wed, Jul 25, 2018 at 4:20 PM, Bruce Ashfield
<bruce.ashfield at gmail.com> wrote:
> On Wed, Jul 25, 2018 at 4:17 PM, Burton, Ross <ross.burton at intel.com> wrote:
>> On 25 July 2018 at 21:05, Bruce Ashfield <bruce.ashfield at gmail.com> wrote:
>>> My question about the change .. is why ? I really don't like cleanup
>>> patches on principle, and want things pinned to a bug, a performance
>>> issue or something else.
>>
>> See a post by RP to the oe-core list a few days ago: a general cleanup
>> of Python code that spawns is well overdue.  In this case
>> oe.utils.getstatusoutpus is a wrapper that just calls a deprecated
>> function in subprocess, is best to pass arguments as an array instead
>> of string, best not to use a shell, etc.
>
> ah ok.
>
> I still don't like it, but it is what it is.

... and I found the original email, I see the part about things being
depreciated. Makes sense.

I'll queue it up and run some tests on some intentionally bad BSPs.

Bruce

>
> My comment stands, I'll figure out how to incorporate this and send it
> along with my next pull request.
>
> Bruce
>
>>
>> Ross
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"



More information about the Openembedded-core mailing list