[OE-core] [PATCH] tune-i586-nlp.inc: drop tuning file for Intel Quark/X1000 CPU

[Mark Hatle]

On 6/1/18 12:21 PM, Andre McCurdy wrote:
> On Fri, Jun 1, 2018 at 7:58 AM, Mark Hatle <mark.hatle at windriver.com> wrote:
>> On 5/31/18 6:10 PM, Andre McCurdy wrote:
>>> The Quark machine was EOL'ed at the end of 2017 and all support for
>>> it has now been removed from meta-intel. Drop the associated tuning
>>> file from oe-core.
>>
>> I would rather this remain.  There are still a lot of people using the quark
>> based boards as hobbyists... there is little effort to maintain it for now.
>>
>> (we still have support for ARMv4 for instance, which hasn't really been used in
>> new designs in a while..)
> 
> Is there ever a case when we would drop old tuning files? Or should
> they live on forever?

If we actively know they do not work any longer, (which is probably when GCC
support is declared to be obsolete.)

> We dropped GPLv2 recipes from oe-core on the grounds that they are
> old, unmaintained and untested. ARMv4 CPU tuning files meet those
> criteria too.

I'm not sure they are unmaintained, but certainly untested.  We've had and
continue to get contributions to tuning files that are clearly never tested.

(Besides, a lot of us don't use meta-intel, we use our own BSP layers..)

--Mark

>>>   http://git.yoctoproject.org/cgit.cgi/meta-intel/commit/?id=5dbc69e339588834317b632119717996584b0d6c
>>>
>>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>>> ---
>>>  meta/conf/machine/include/tune-i586-nlp.inc | 19 -------------------
>>>  1 file changed, 19 deletions(-)
>>>  delete mode 100644 meta/conf/machine/include/tune-i586-nlp.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-i586-nlp.inc b/meta/conf/machine/include/tune-i586-nlp.inc
>>> deleted file mode 100644
>>> index 88e5903..0000000
>>> --- a/meta/conf/machine/include/tune-i586-nlp.inc
>>> +++ /dev/null
>>> @@ -1,19 +0,0 @@
>>> -# Settings for the GCC(1) cpu-type "quark":
>>> -#
>>> -#
>>> -#
>>> -DEFAULTTUNE ?= "i586-nlp-32"
>>> -
>>> -# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
>>> -require conf/machine/include/x86/arch-x86.inc
>>> -
>>> -# x86 with no lock prefix
>>> -TUNEVALID[i586-nlp] = "IA32 with Lock Prefix omitted"
>>> -TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'i586-nlp', ' -march=i586 -Wa,-momit-lock-prefix=yes', '', d)}"
>>> -
>>> -# Quark tune feature
>>> -AVAILTUNES = "i586-nlp-32"
>>> -TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
>>> -BASE_LIB_tune-i586-nlp-32 = "lib"
>>> -TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
>>> -PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"
>>>
>>