[OE-core] [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI

Oleksandr Kravchuk open.source at oleksandr-kravchuk.com
Sat Jun 2 21:38:33 UTC 2018


No feelings were touched. I should have indeed explained why the SRC_URI 
was changed.

I'll update the patch. Cheers.

On 02/06/18 23:35, Alexander Kanavin wrote:
> I'm sorry for being terse. Reviewing patches before morning coffee is
> not always a great idea.
>
> When changing SRC_URI, you still need to explain in the commit message
> what's wrong with the old URI and how the new URI was chosen.
>
> Specifically here, alioth is not temporarily down, it has been
> deliberately taken offline:
>
> https://wiki.debian.org/Alioth
>
> and the same wiki page lists salsa.debian.org as the successor. Any
> debian-driven projects are likely to have been moved there, and so
> that's the first place I had checked.
>
> Alex
>
> 2018-06-02 16:35 GMT+03:00 Oleksandr Kravchuk
> <open.source at oleksandr-kravchuk.com>:
>> On 02/06/18 07:19, Alexander Kanavin wrote:
>>> 2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
>>> <open.source at oleksandr-kravchuk.com>:
>>>>    SRC_URI =
>>>> "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz"
>>>> +SRC_URI =
>>>> "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz"
>>> The correct new URI is
>>> https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
>>> ftp from google search results please.
>>>
>>> Alex
>> It is not always easy to find "the new" official URI. I took the one that
>> was around for a long time, not "a random ftp from google search results".
>>
>> I will fix and resend the patch.



More information about the Openembedded-core mailing list