[OE-core] [PATCH 05/16] xinetd: add Init Script Actions to xinetd script

[Richard Purdie]

On Mon, 2018-06-04 at 10:30 +0800, Robert Yang wrote:
> 
> On 06/03/2018 11:59 PM, Richard Purdie wrote:
> > On Wed, 2018-05-30 at 17:03 +0800, Robert Yang wrote:
> > > From: Shan Hai <shan.hai at windriver.com>
> > > 
> > > The chkconfig fails to list the xinetd service because the xinetd
> > > lacks Init Script Actions in it, add the actions to fix it.
> > > 
> > > Signed-off-by: Shan Hai <shan.hai at windriver.com>
> > > Signed-off-by: Mingli Yu <Mingli.Yu at windriver.com>
> > > ---
> > >   meta/recipes-extended/xinetd/xinetd/xinetd.init | 12
> > > +++++++++++-
> > >   1 file changed, 11 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-extended/xinetd/xinetd/xinetd.init
> > > b/meta/recipes-extended/xinetd/xinetd/xinetd.init
> > > index 777c2c8..a021410 100644
> > > --- a/meta/recipes-extended/xinetd/xinetd/xinetd.init
> > > +++ b/meta/recipes-extended/xinetd/xinetd/xinetd.init
> > > @@ -1,5 +1,15 @@
> > >   #!/bin/sh
> > > -#
> > > +### BEGIN INIT INFO
> > > +# Provides:          inetd
> > > +# Required-Start:    $local_fs $remote_fs
> > > +# Required-Stop:     $local_fs $remote_fs
> > > +# Should-Start:      $syslog
> > > +# Should-Stop:       $syslog
> > > +# Default-Start:     2 3 4 5
> > > +# Default-Stop:      0 1 6
> > > +# Short-Description: Start or stop the xinetd daemon.
> > > +### END INIT INFO
> > > +
> > 
> > Have we some kind of policy which says all init scripts have to
> > have a
> > header like this? I'm wondering why this is just getting applied
> > for
> > xinetd when there are probably other init scripts which don't have
> > this. Are we planning to add this everywhere?
> 
> We added this is because customer requires, and only for this one. We
> don't have any plan to add more.

I don't see the need to have this in OE-Core, it just duplicates
information from the recipe which can easily become outdated...

Cheers,

Richard