[OE-core] [RFC] u-boot.inc: Support menuconfig for u-boot

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: Vineeth Chowdary [mailto:vineeth.chowdary at xilinx.com]
> Sent: Monday, June 04, 2018 2:15 AM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>
> Cc: openembedded-core at lists.openembedded.org
> Subject: Re: [OE-core] [RFC] u-boot.inc: Support menuconfig for u-boot
> 
> Hi Manju,
> 
> On Mon, May 28, 2018 at 10:44:57PM -0700, Manjukumar Matha wrote:
> > u-boot mainline supports menuconfig and is slowing moving drivers to
> > be enabled using menuconfig. This patch enables menuconfig for u-boot using
> cml1.
> >
> > However using menuconfig in conjuntion with UBOOT_CONFIG cannot happen.
> > When you run menuconfig it is against a particular defconfig, while
> > using UBOOT_CONFIG, you can have different defconfig.
> >
> > Tested with beaglebone-yocto machine and zcu102-zynqmp machine in
> > meta-xilinx layer.
> >
> > Signed-off-by: Manjukumar Matha
> > <manjukumar.harthikote-matha at xilinx.com>
> > ---
> >  meta/recipes-bsp/u-boot/u-boot.inc | 28 ++++++++++++++++++++++++++--
> >  1 file changed, 26 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-bsp/u-boot/u-boot.inc
> > b/meta/recipes-bsp/u-boot/u-boot.inc
> > index c2bcf99..cd8b8d3 100644
> > --- a/meta/recipes-bsp/u-boot/u-boot.inc
> > +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> > @@ -5,7 +5,9 @@ B = "${WORKDIR}/build"
> >
> >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> >
> > -inherit uboot-config uboot-extlinux-config uboot-sign deploy
> > +DEPENDS += "kern-tools-native"
> > +
> > +inherit uboot-config uboot-extlinux-config uboot-sign deploy cml1
> >
> >  EXTRA_OEMAKE = 'CROSS_COMPILE=${TARGET_PREFIX}
> CC="${TARGET_PREFIX}gcc ${TOOLCHAIN_OPTIONS}" V=1'
> >  EXTRA_OEMAKE += 'HOSTCC="${BUILD_CC} ${BUILD_CFLAGS}
> ${BUILD_LDFLAGS}"'
> > @@ -63,6 +65,29 @@ UBOOT_EXTLINUX_INSTALL_DIR ?= "/boot/extlinux"
> >  UBOOT_EXTLINUX_CONF_NAME ?= "extlinux.conf"
> >  UBOOT_EXTLINUX_SYMLINK ?= "${UBOOT_EXTLINUX_CONF_NAME}-
> ${MACHINE}-${PR}"
> >
> > +# returns all the elements from the src uri that are .cfg files def
> > +find_cfgs(d):
> > +    sources=src_patches(d, True)
> > +    sources_list=[]
> > +    for s in sources:
> > +        if s.endswith('.cfg'):
> > +            sources_list.append(s)
> > +
> > +    return sources_list
> > +
> > +do_configure () {
> > +    if [ -z "${UBOOT_CONFIG}" ]
> > +    then
> > +        if [ -n "${UBOOT_MACHINE}" ]; then
> > +            oe_runmake -C ${S} O=${B} ${UBOOT_MACHINE}
> > +        else
> > +            oe_runmake -C ${S} O=${B} oldconfig
> > +        fi
> > +        merge_config.sh -m .config ${@" ".join(find_cfgs(d))}
> 
> I think dependencies will not be resolved if we append at the end and reparse ?
> 

Can you provide more details or test-case which resulted in the breakage?
I have followed busybox implementation of menuconfig here

Thanks,
Manju

<...>