[OE-core] [PATCH 1/7] openssh: stop adding -D__FILE_OFFSET_BITS=64 to CFLAGS

[Burton, Ross]

Looks good to me, marked for MUT.

Ross

On 12 June 2018 at 18:38, Andre McCurdy <armccurdy at gmail.com> wrote:
> On Thu, Jun 7, 2018 at 11:48 AM, Andre McCurdy <armccurdy at gmail.com> wrote:
>> Openssh takes care of enabling large-file support automatically via
>> the AC_SYS_LARGEFILE in the configure.ac, so additional help from the
>> recipe is not required.
>>
>> Even if it were once required, defining __FILE_OFFSET_BITS (ie with
>> double leading underscores) looks like a typo and probably never had
>> any effect anyway?
>
> Ping.
>
> Any issues with this (the whole series of 7)?
>
>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> ---
>>  meta/recipes-connectivity/openssh/openssh_7.7p1.bb | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/meta/recipes-connectivity/openssh/openssh_7.7p1.bb b/meta/recipes-connectivity/openssh/openssh_7.7p1.bb
>> index 7b6ee5c..7cf34eb 100644
>> --- a/meta/recipes-connectivity/openssh/openssh_7.7p1.bb
>> +++ b/meta/recipes-connectivity/openssh/openssh_7.7p1.bb
>> @@ -46,9 +46,6 @@ SYSTEMD_SERVICE_${PN}-sshd = "sshd.socket"
>>
>>  inherit autotools-brokensep ptest
>>
>> -# LFS support:
>> -CFLAGS += "-D__FILE_OFFSET_BITS=64"
>> -
>>  EXTRA_AUTORECONF += "--exclude=aclocal"
>>
>>  # login path is hardcoded in sshd
>> --
>> 1.9.1
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core