[OE-core] [PATCH] atk: Correct multilib conflict in header.

Alexander Kanavin alex.kanavin at gmail.com
Thu Jun 14 06:50:51 UTC 2018


2018-06-13 23:15 GMT+03:00 Jeremy Puhlman <jpuhlman at mvista.com>:
> +do_install_append () {
> +   if [ -e ${D}${includedir}/atk-1.0/atk/atk-enum-types.h ] ; then
> +      sed -i ${D}${includedir}/atk-1.0/atk/atk-enum-types.h -e "s,${B},,"
> +   fi
> +}

Instead of patching it after the fact during installation, can you
patch it at the source please? Then we have at least a chance of the
fix being accepted upstream, instead of carrying it forever.

Also, do include comments: we try to avoid recipe snippets that do
'magic' without any explanation.

Alex



More information about the Openembedded-core mailing list