[OE-core] [PATCH] boost: Improve reproducibility

[Khem Raj]

On 6/1/18 12:34 PM, Alexander Kanavin wrote:
> On 06/01/2018 09:33 PM, Khem Raj wrote:
>>> The .s file is not generated and it does not contain any .file
>>> directives. The .o file also does not contain the path. It appears in
>>> the final .so library at linking stage.
>>
>> Can you share the linker cmdline ?
> 
> https://pastebin.com/WK9GVDfj
> 
> Note that of the three assembly-generated object files, only the path to 
> the first shows up in the .so - because of assembly labels I believe.
> 

Thanks for sharing this. If there is a no file directive in an object 
file then linker will use whatever is specified on linker cmdline so 
thats what we see, We should define FILE symbol explicitly for .S files 
here, for C/C++ files compiler does that automatically.

Other files dont make a claim in final symbol table since this one file 
alone has cross referencing to symbols from other objects.

Something like this will help

Index: boost_1_67_0/libs/context/src/asm/make_i386_sysv_elf_gas.S
===================================================================
--- boost_1_67_0.orig/libs/context/src/asm/make_i386_sysv_elf_gas.S
+++ boost_1_67_0/libs/context/src/asm/make_i386_sysv_elf_gas.S
@@ -23,7 +23,7 @@
   * 
---------------------------------------------------------------------------------- 
  *
   * 
                  *
 
****************************************************************************************/
-
+.file "make_i386_sysv_elf_gas.S"
  .text
  .globl make_fcontext
  .align 2
Index: boost_1_67_0/libs/context/src/asm/make_x86_64_sysv_elf_gas.S
===================================================================
--- boost_1_67_0.orig/libs/context/src/asm/make_x86_64_sysv_elf_gas.S
+++ boost_1_67_0/libs/context/src/asm/make_x86_64_sysv_elf_gas.S
@@ -23,7 +23,7 @@
   * 
---------------------------------------------------------------------------------- 
  *
   * 
                  *
 
****************************************************************************************/
-
+.file "make_x86_64_sysv_elf_gas.S"
  .text
  .globl make_fcontext
  .type make_fcontext, at function

> Alex