[OE-core] [OE-Core][PATCH 1/2] kernel-fitimage: Allow setting of DTB/DTBO relocation address

[Martin Hundebøll]

Hi Alex,

On 2018-06-16 09:17, Alex Kiernan wrote:
> Introduce UBOOT_DTB_LOADADDRESS and UBOOT_DTBO_LOADADDRESS so that you
> can set where U-Boot loads full and overlay DTBs. This is required when
> using bootm's overlay support to construct the final DTB.
> 
> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
> ---
> This commit conflicts with this patch:
> 
> https://patchwork.openembedded.org/series/12589/
> 
> Either that needs applying first and this needs rebasing on top of it, or
> use this one in its place.
> 
>   meta/classes/kernel-fitimage.bbclass | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 50a91e1..f3c2ff0 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -135,6 +135,15 @@ fitimage_emit_section_dtb() {
>   
>   	dtb_csum="sha1"
>   
> +	dtb_loadline=""
> +	dtb_ext=${DTB##*.}
> +	if [ "${dtb_ext}" = "dtbo" ]; then
> +		if [ -n "${UBOOT_DTBO_LOADADDRESS}" ]; then
> +			dtb_loadline="load = <${UBOOT_DTBO_LOADADDRESS}>;"
> +		fi
> +	elif [ -n "${UBOOT_DTB_LOADADDRESS}" ]; then
> +		dtb_loadline="load = <${UBOOT_DTB_LOADADDRESS}>;"
> +	fi

I haven't looked into the use of DTB overlays in fitimages, but 
shouldn't it be possible to specify multiple overlays?

 From the way I read your patch, only a single overlay is supported...

// Martin

>   	cat << EOF >> ${1}
>                   fdt@${2} {
>                           description = "Flattened Device Tree blob";
> @@ -142,6 +151,7 @@ fitimage_emit_section_dtb() {
>                           type = "flat_dt";
>                           arch = "${UBOOT_ARCH}";
>                           compression = "none";
> +                        ${dtb_loadline}
>                           hash at 1 {
>                                   algo = "${dtb_csum}";
>                           };
> 

-- 
Kind regards,
Martin Hundebøll
Embedded Linux Consultant

+45 61 65 54 61
martin at geanix.com

Geanix IVS
DK39600706