[OE-core] [meta-oe][PATCH] image_types.bbclass: add optional size to ubi vols

[Andre McCurdy]

On Mon, Jun 18, 2018 at 4:29 AM, Tobias Olausson <TOl at hms.se> wrote:
> From d7b8be3f844c10ace0d4c04e35986145fc20d0d8 Mon Sep 17 00:00:00 2001
> From: Tobias Olausson <tol at hms.se>
> Date: Mon, 18 Jun 2018 13:22:04 +0200
> Subject: [meta-oe][PATCH] image_types.bbclass: add optional size to ubi vols
>
> Instead of hard coding the ubi volume to be just large enough to fit the
> root file system, one can use a variable to set a preferred size.
>
> Signed-off-by: Tobias Olausson <tol at hms.se>
> ---
>  meta/classes/image_types.bbclass | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 00a00d318f..ae23aeaa8a 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -164,10 +164,18 @@ multiubi_mkfs() {
>                 local vname="_$3"
>         fi
>
> +       # Set UBI_VOL_SIZE (for regular ubi) or UBI_VOL_SIZE_name for multiubi
> +       eval local UBI_VOL_SIZE=\"\$UBI_VOL_SIZE_${name}\"

If UBI_VOL_SIZE is a shell variable then by convention it should be
lower case (to avoid confusion with bitbake variables, which are upper
case). Also, where is the variable ${name} coming from? Should it be
${vname} ?

> +
>         echo \[ubifs\] > ubinize${vname}-${IMAGE_NAME}.cfg
>         echo mode=ubi >> ubinize${vname}-${IMAGE_NAME}.cfg
>         echo image=${IMGDEPLOYDIR}/${IMAGE_NAME}${vname}${IMAGE_NAME_SUFFIX}.ubifs >> ubinize${vname}-${IMAGE_NAME}.cfg
>         echo vol_id=0 >> ubinize${vname}-${IMAGE_NAME}.cfg
> +
> +       if [ -n "${UBI_VOL_SIZE}" ]; then
> +               echo "vol_size=${UBI_VOL_SIZE}" >> ubinize${vname}-${IMAGE_NAME}.cfg
> +       fi
> +
>         echo vol_type=dynamic >> ubinize${vname}-${IMAGE_NAME}.cfg
>         echo vol_name=${UBI_VOLNAME} >> ubinize${vname}-${IMAGE_NAME}.cfg
>         echo vol_flags=autoresize >> ubinize${vname}-${IMAGE_NAME}.cfg
> --
> 2.17.1
>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core