[OE-core] [oe-core][PATCHv2] image_types.bbclass: add optional size to ubi vols
Andre McCurdy
armccurdy at gmail.com
Mon Jun 18 22:10:44 UTC 2018
On Mon, Jun 18, 2018 at 6:14 AM, Tobias Olausson <TOl at hms.se> wrote:
> From 6bd1c95cc26aebe820e3d83a97601e4057ef8db5 Mon Sep 17 00:00:00 2001
> From: Tobias Olausson <tol at hms.se>
> Date: Mon, 18 Jun 2018 15:01:53 +0200
> Subject: [oe-core][PATCHv2] image_types.bbclass: add optional size to ubi vols
>
> Instead of hard coding the ubi volume to be just large enough to fit the
> root file system, one can use a variable to set a preferred size.
>
> Signed-off-by: Tobias Olausson <tol at hms.se>
> ---
> meta/classes/image_types.bbclass | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 00a00d318f..c53fb1fce4 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -164,10 +164,22 @@ multiubi_mkfs() {
> local vname="_$3"
> fi
>
> + # Set UBI_VOL_SIZE (for regular ubi) or UBI_VOL_SIZE_vname for multiubi
> + if [ -n ${vname} ]; then
You need to quote ${vname} here, otherwise the test will always return true:
$ [ -n ] && echo true
true
$ [ -n foo ] && echo true
true
Wondering how much testing this patch has actually had ?
> + local ubi_vol_size=${UBI_VOL_SIZE}
> + else
> + eval local ubi_vol_size=\"\$UBI_VOL_SIZE${vname}\"
> + fi
> +
> echo \[ubifs\] > ubinize${vname}-${IMAGE_NAME}.cfg
> echo mode=ubi >> ubinize${vname}-${IMAGE_NAME}.cfg
> echo image=${IMGDEPLOYDIR}/${IMAGE_NAME}${vname}${IMAGE_NAME_SUFFIX}.ubifs >> ubinize${vname}-${IMAGE_NAME}.cfg
> echo vol_id=0 >> ubinize${vname}-${IMAGE_NAME}.cfg
> +
> + if [ -n "${ubi_vol_size}" ]; then
> + echo "vol_size=${ubi_vol_size}" >> ubinize${vname}-${IMAGE_NAME}.cfg
> + fi
> +
> echo vol_type=dynamic >> ubinize${vname}-${IMAGE_NAME}.cfg
> echo vol_name=${UBI_VOLNAME} >> ubinize${vname}-${IMAGE_NAME}.cfg
> echo vol_flags=autoresize >> ubinize${vname}-${IMAGE_NAME}.cfg
> --
> 2.17.1
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
More information about the Openembedded-core
mailing list